Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760938AbYBFH4k (ORCPT ); Wed, 6 Feb 2008 02:56:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759799AbYBFH4b (ORCPT ); Wed, 6 Feb 2008 02:56:31 -0500 Received: from pasmtpa.tele.dk ([80.160.77.114]:49674 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759318AbYBFH4b (ORCPT ); Wed, 6 Feb 2008 02:56:31 -0500 Date: Wed, 6 Feb 2008 08:56:35 +0100 From: Sam Ravnborg To: Dmitry Torokhov Cc: Andrew Morton , Linus Torvalds , LKML Subject: Re: [git pull] Input updates for 2.6.25-rc0 Message-ID: <20080206075635.GA6354@uranus.ravnborg.org> References: <200802060108.31644.dtor@insightbb.com> <20080205223242.f444fad6.akpm@linux-foundation.org> <200802060149.50879.dtor@insightbb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802060149.50879.dtor@insightbb.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 628 Lines: 23 > > > > > > > > > i8042_platform_init(): > > > > +#if defined(__i386__) || defined(__x86_64__) > > > > use #ifdef CONFIG_X86? > > > > I considered it but above was tested and in line with the style of the > rest of the file... Then please change the rest of the file so it is consistent with the usual style to use our CONFIG_ symbols for conditionals like the above. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/