Received-SPF: pass (google.com: domain of linux-kernel+bounces-206637-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240605135841.97446-1-thorsten.blum@toblux.com>
In-Reply-To: <20240605135841.97446-1-thorsten.blum@toblux.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 7 Jun 2024 20:58:18 +0200
Message-ID: <CAJZ5v0jQi_7LQWRSXngxAwByKKDcikRx4Vu9Mjj86dMqCTzMCQ@mail.gmail.com>
Subject: Re: [PATCH] powercap: idle_inject: Simplify if condition
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 5, 2024 at 3:59=E2=80=AFPM Thorsten Blum <thorsten.blum@toblux.=
com> wrote:
>
> The if condition !A || A && B can be simplified to !A || B.
>
> Fixes the following Coccinelle/coccicheck warning reported by
> excluded_middle.cocci:
>
>         WARNING !A || A && B is equivalent to !A || B
>
> Compile-tested only.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
>  drivers/powercap/idle_inject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_injec=
t.c
> index e18a2cc4e46a..bafc59904ed3 100644
> --- a/drivers/powercap/idle_inject.c
> +++ b/drivers/powercap/idle_inject.c
> @@ -127,7 +127,7 @@ static enum hrtimer_restart idle_inject_timer_fn(stru=
ct hrtimer *timer)
>         struct idle_inject_device *ii_dev =3D
>                 container_of(timer, struct idle_inject_device, timer);
>
> -       if (!ii_dev->update || (ii_dev->update && ii_dev->update()))
> +       if (!ii_dev->update || ii_dev->update())
>                 idle_inject_wakeup(ii_dev);
>
>         duration_us =3D READ_ONCE(ii_dev->run_duration_us);
> --

Applied as 6.11 material, thanks!