Received-SPF: pass (google.com: domain of linux-kernel+bounces-206631-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, liam.howlett@oracle.com,
        willy@infradead.org, Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH v2 13/16] maple_tree: have mas_store() allocate nodes if needed
Date: Fri,  7 Jun 2024 11:52:54 -0700
Message-ID: <20240607185257.963768-14-sidhartha.kumar@oracle.com>
In-Reply-To: <20240607185257.963768-1-sidhartha.kumar@oracle.com>
References: <20240607185257.963768-1-sidhartha.kumar@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?UAkL086aNNkJBVJ6KNlYuk7wJPuOLFlzsEkiqUKJrhmDC5qFy+Owabgn6Nt7?=
 =?us-ascii?Q?619FAvy3gslew2Am9dQ74jUWUY4dnX1YPnSs9AZF+0Ui6DIpDdGY1vtIvSQF?=
 =?us-ascii?Q?OMRE2jDyD2sXtML8jmn9iGDxuuLDMakWJsTw97nC3plVjy3Wu3U5/DdW6zv4?=
 =?us-ascii?Q?WLwvvX0hWS/dpH1if7/RUs52AhU/hBg/ThdqLO0AUDvOwu3DrBX66ZMenRSx?=
 =?us-ascii?Q?17SF1CZi3q8C8KYNMHOiwP7XWWt2q4obeNkHZIrcKR9x6qrBHdrXa9Nvk/QR?=
 =?us-ascii?Q?V9mfW5Xr3t2Qbo/X13QWnm5Xj+4URogKrbd6Y93WcvVV//ocG81sWYwRmW8m?=
 =?us-ascii?Q?FxSXJE9S52kqS11ZXlhk2bkDko/dYjmzP+tIBMn8P2o+dJnxGv8VSFoy94rV?=
 =?us-ascii?Q?547h1+GhIZwnm0zQ0Hukm6DWAnrxHL5ywBtrXGtkLfWQ01SpGv/rv/RYnXTv?=
 =?us-ascii?Q?itLG6VvQJKFKx3aEhP6VQqvWSr9awqnjOqux/rrPggXo9Km5ws37M8ah7Qvk?=
 =?us-ascii?Q?FgAsCGhR+8C4lZqbaE9VcPZ5Y0QXY5DiHASAI/9R9mlebZeJrplMsBRiOIL3?=
 =?us-ascii?Q?bCLT89LBrc39gAxNY0Jf+MhbD3IrPWowc1W1PI/2Dt2/V5+Je4+Ab7eAOKU6?=
 =?us-ascii?Q?9g9mo94LMS7iOKzIWNngzez8+HU4XEYtIsnt6snaDQ57ZPNVnFYY2Z85QJIG?=
 =?us-ascii?Q?XH7Z8ujyvoGot7QXXcYKnfGgrvPGu9HxDlo5kuDvqIGv/ujtA0JR+9nWlYRY?=
 =?us-ascii?Q?8C/cuBTy9Cmfs4eUXMMO7nzxx2SSIKFI8KJVjJLOS+aJYlaVlPVulirMt1Wb?=
 =?us-ascii?Q?xwLsHFy5uVrMgCVxcr0JQhKq6SqLyq7bToz4c2n17Fq7IAublKpCJVKCa3Sv?=
 =?us-ascii?Q?euQ/VDPZhoVn05hhRdNOTIOqn06Cf/EzMLqw6PWb9eWySTczAD/loHTrhU3e?=
 =?us-ascii?Q?wlnl0pheX2IR/rOnQJbUdFes9+Ip0VGKq3EAXn3cx66l7rKQ26fzF9ipppvB?=
 =?us-ascii?Q?uRWh6cp/IytLSLbuoCqoyEloYkK13qG9WRYt3p7/RBj0Fh3VriLCBRGzBVCt?=
 =?us-ascii?Q?lrsYoq0EKddWmUQLTnxfXJrdbIQbCKq0ezqol2KQS8nKwU+lkGfSSCv9d90Q?=
 =?us-ascii?Q?6kmgJ/bRoLFavOSCU5n12bfvcbR1ef0SrDNqc/o90Kq8Z7zlFhk7LrmX/jm5?=
 =?us-ascii?Q?lfg/Ox8CnvkPKQsnHJwO14OQZHbmFJcToccdW9065n4WLJE8ovRDuuLix5Vg?=
 =?us-ascii?Q?PRD0ccJ2NmFIXIkw6aSEZ6pTfoahQHrL8euxhScspR/d2o6Ly93zGWP5+nf+?=
 =?us-ascii?Q?zp8bqI2J4PxPbb1LcF35n/o0cfqWQPSgMiNz28xoBYELILmwR/JYXFhTS1sK?=
 =?us-ascii?Q?EAGKKDrEytvwb+kpbRfrtm/0ztgtassE9A9FWlhoxVtBQqWJqnehfHrW+A19?=
 =?us-ascii?Q?gPR9Q7GTZIRV8JrVYuyFGOWFgeK76rL+0xd53hozd1AB7D5IwSajTdzJoEuG?=
 =?us-ascii?Q?3xjbh6+PF2YzpiQsr+3vWPnhzGMfb7WebPS8YBuwG5kTCwNPTJM+eNsV9CSf?=
 =?us-ascii?Q?1/oizU6W9/XJOVgSP1Yzrznmig/WxGv8fcEMaBnI6v4FZe/qJJ4gdLSt2ZFQ?=
 =?us-ascii?Q?KgGbdJJAdeipltV2ghrk2i8=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	TxWphX6prQRgD2Eigb06bq5OSzoICFgHJ3bjLdaWD7Nfl7MSmH1Zx4SNn9F2c6DX9eIc4uL6AKnvINQSVKKNoPZez3gwKczIz4Ltx4Bv7tZsiKDsNWHD3qDiy7HrDxD5tu+qUZLsatBTRbO8c5eTGcWJjy93m5LBniQSMLNqyBkATgQDR+OOrurQCfLDL69NM1ukU9gIuT080Y36QIUxwMgH5/SIYpe79N7PS+ZuHXR89hOVb0dy32J7+Oqrfxgl250snQM+7HSIeBxN1B+OK0YO6BwqFeWKRrdXUgntiIaSMg9KxNRJsIZ8hMNEWSXI6yXADUgOBxd4K1wSWwYOZhmHwqTejmgo5aP+u+dzmPKssO6J9MMl6uldLUIIR58GvoUPglxxRPOtI7z75r1MSUDf0see+N55WYEapDEqYEjjNpbbYicO4uKIx12W01IGUrErMYPVfs3PSshgGRQNe743VdES3Wfwstg6DJeYmWdWzXUfnhncltACWw+EqLzkrQK/03VmHVClnWPITmZRLPYG+OBIxJK8veYgodXaBNvAAHs9Gq4SkhbUCmfVvQ/tPff/uwAdM4waPx9eURxftDMhxSj3uGvzQkcReXhijPY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d5fd1d0-3b0e-46ff-0e86-08dc87232671
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5117.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 18:53:43.6410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0KuC6v8vzSoxfQ8bqyafBMwx4z8AK2/RhbGypHyxSmgmImQxv5vbWefcCYoS/8WDuSG4PGEjS0JeTg3cZE/QxcnEZ4ToOgJciiFRrQR0Q/w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6640
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-07_11,2024-06-06_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406070138
X-Proofpoint-ORIG-GUID: kMzbxoZGb6okFKYZ3_q_lPtin-gZ5thz
X-Proofpoint-GUID: kMzbxoZGb6okFKYZ3_q_lPtin-gZ5thz

Not all users of mas_store() enter with nodes already preallocated.
Check for the MA_STATE_PREALLOC flag to decide whether to preallocate nodes
within mas_store() rather than relying on future write helper functions
to perform the allocations. This allows the write helper functions to be
simplified as they do not have to do checks to make sure there are
enough allocated nodes to perform the write.

Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
---
 lib/maple_tree.c | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 8b17768db5f2..92f133ea5f00 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5528,6 +5528,20 @@ static inline void mte_destroy_walk(struct maple_enode *enode,
 		mt_destroy_walk(enode, mt, true);
 	}
 }
+
+static inline void mas_wr_store_prealloc(struct ma_wr_state *wr_mas, void *entry)
+{
+	struct ma_state *mas = wr_mas->mas;
+	int request;
+
+	mas_wr_prealloc_setup(wr_mas);
+	mas_wr_store_type(wr_mas);
+	request = mas_prealloc_calc(mas, entry);
+	if (!request)
+		return;
+
+	mas_node_count(mas, request);
+}
 /* Interface */
 
 /**
@@ -5536,8 +5550,6 @@ static inline void mte_destroy_walk(struct maple_enode *enode,
  * @entry: The entry to store.
  *
  * The @mas->index and @mas->last is used to set the range for the @entry.
- * Note: The @mas should have pre-allocated entries to ensure there is memory to
- * store the entry.  Please see mas_expected_entries()/mas_destroy() for more details.
  *
  * Return: the first entry between mas->index and mas->last or %NULL.
  */
@@ -5563,9 +5575,21 @@ void *mas_store(struct ma_state *mas, void *entry)
 	 * want to examine what happens if a single store operation was to
 	 * overwrite multiple entries within a self-balancing B-Tree.
 	 */
-	mas_wr_prealloc_setup(&wr_mas);
-	mas_wr_store_type(&wr_mas);
+	if (mas->mas_flags & MA_STATE_PREALLOC) {
+		mas_wr_prealloc_setup(&wr_mas);
+		mas_wr_store_type(&wr_mas);
+		mas_wr_store_entry(&wr_mas);
+		MAS_WR_BUG_ON(&wr_mas, mas_is_err(mas));
+		return wr_mas.content;
+	}
+
+	mas_wr_store_prealloc(&wr_mas, entry);
+	WARN_ON_ONCE(mas->store_type == wr_invalid);
+	if (mas_is_err(mas))
+		return NULL;
+
 	mas_wr_store_entry(&wr_mas);
+	mas_destroy(mas);
 	return wr_mas.content;
 }
 EXPORT_SYMBOL_GPL(mas_store);
-- 
2.45.2