Received-SPF: pass (google.com: domain of linux-kernel+bounces-206640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <AS8PR02MB723748EF627AEB253C437FD48BFA2@AS8PR02MB7237.eurprd02.prod.outlook.com>
In-Reply-To: <AS8PR02MB723748EF627AEB253C437FD48BFA2@AS8PR02MB7237.eurprd02.prod.outlook.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 7 Jun 2024 21:00:29 +0200
Message-ID: <CAJZ5v0ghxCYZKdf3zixi6StSCir7Yyiy5iyPeG2+GmyHU4yzWw@mail.gmail.com>
Subject: Re: [PATCH] thermal: int3400: Use sizeof(*pointer) instead of sizeof(type)
To: Erick Archer <erick.archer@outlook.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Zhang Rui <rui.zhang@intel.com>, Lukasz Luba <lukasz.luba@arm.com>, 
	srinivas pandruvada <srinivas.pandruvada@linux.intel.com>, 
	=?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, 
	Ard Biesheuvel <ardb@kernel.org>, Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>, 
	Lukas Wunner <lukas@wunner.de>, Kees Cook <keescook@chromium.org>, 
	"Gustavo A. R. Silva" <gustavoars@kernel.org>, Justin Stitt <justinstitt@google.com>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 6, 2024 at 7:21=E2=80=AFPM Erick Archer <erick.archer@outlook.c=
om> wrote:
>
> It is preferred to use sizeof(*pointer) instead of sizeof(type)
> due to the type of the variable can change and one needs not
> change the former (unlike the latter). This patch has no effect
> on runtime behavior.
>
> Signed-off-by: Erick Archer <erick.archer@outlook.com>
> ---
>  drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/dr=
ivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index fa96972266e4..b0c0f0ffdcb0 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -571,7 +571,7 @@ static int int3400_thermal_probe(struct platform_devi=
ce *pdev)
>         if (!adev)
>                 return -ENODEV;
>
> -       priv =3D kzalloc(sizeof(struct int3400_thermal_priv), GFP_KERNEL)=
;
> +       priv =3D kzalloc(sizeof(*priv), GFP_KERNEL);
>         if (!priv)
>                 return -ENOMEM;
>
> --

Applied as 6.11 material, thanks!