Received-SPF: pass (google.com: domain of linux-kernel+bounces-206645-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240606181214.2456266-1-srinivas.pandruvada@linux.intel.com>
In-Reply-To: <20240606181214.2456266-1-srinivas.pandruvada@linux.intel.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 7 Jun 2024 21:08:28 +0200
Message-ID: <CAJZ5v0i8RnWs9OgxxqVOCG4RHhN7X3ELcruPoGrS1iP8hNSGsw@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: Update Meteor Lake EPPs
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: rafael@kernel.org, viresh.kumar@linaro.org, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 6, 2024 at 8:12=E2=80=AFPM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> Update the default balance_performance EPP to 64. This gives better
> performance and also perf/watt compared to current value of 115.
>
> For example:
>
> Speedometer 2.1
>         score: +19%
>         Perf/watt: +5.25%
>
> Webxprt 4 score
>         score: +12%
>         Perf/watt: +6.12%
>
> 3DMark Wildlife extreme unlimited score
>         score: +3.2%
>         Perf/watt: +11.5%
>
> Geekbench6 MT
>         score: +2.14%
>         Perf/watt: +0.32%
>
> Also update balance_power EPP default to 179. With this change:
>         Video Playback power is reduced by 52%
>         Team video conference power is reduced by 35%
>
> With Power profile daemon now sets balance_power EPP on DC instead of
> balance_performance, updating balance_power EPP will help to extend
> battery life.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstat=
e.c
> index dbbf299f4219..8b0032d6a519 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -3429,7 +3429,7 @@ static const struct x86_cpu_id intel_epp_default[] =
=3D {
>         X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, HWP_SET_DEF_BALANCE_PERF_=
EPP(102)),
>         X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, HWP_SET_DEF_BALANCE_=
PERF_EPP(32)),
>         X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE_L, HWP_SET_EPP_VALUES(HWP_E=
PP_POWERSAVE,
> -                                                       HWP_EPP_BALANCE_P=
OWERSAVE, 115, 16)),
> +                                                                   179, =
64, 16)),
>         {}
>  };
>
> --

Rebased on top of the Tony's series:

https://lore.kernel.org/linux-acpi/20240528184720.56259-1-tony.luck@intel.c=
om/

and applied as 6.11 material.

Thanks!