Received-SPF: pass (google.com: domain of linux-kernel+bounces-206662-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240530151704.282453-1-rui.zhang@intel.com>
In-Reply-To: <20240530151704.282453-1-rui.zhang@intel.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 7 Jun 2024 21:26:19 +0200
Message-ID: <CAJZ5v0iVtb8K0ww8REum6T90bu321sWoKCVUN0t-8Wzv9ZvkYw@mail.gmail.com>
Subject: Re: [PATCH] thermal: intel: intel_pch: Improve cooling log
To: Zhang Rui <rui.zhang@intel.com>
Cc: rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org, 
	linux-pm@vger.kernel.org, pmenzel@molgen.mpg.de, len.brown@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 30, 2024 at 5:17=E2=80=AFPM Zhang Rui <rui.zhang@intel.com> wro=
te:
>
> The intel_pch_thermal cooling mechanism currently only provides one of
> the following final conclusions:
> 1. intel_pch_thermal 0000:00:12.0: CPU-PCH is cool [48C]
> 2. intel_pch_thermal 0000:00:12.0: CPU-PCH is cool [49C] after 30700 ms d=
elay
> 3. intel_pch_thermal 0000:00:12.0: CPU-PCH is hot [60C] after 60000 ms de=
lay. S0ix might fail
> 4. intel_pch_thermal 0000:00:12.0: Wakeup event detected, abort cooling
>
> This does not provide sufficient context about what is happening,
> especially for case 4.
>
> Add one line log to indicate when PCH overheats and the cooling delay
> has started.
>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/thermal/intel/intel_pch_thermal.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/=
intel/intel_pch_thermal.c
> index f5be2c389351..fc326985796c 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -298,6 +298,11 @@ static int intel_pch_thermal_suspend_noirq(struct de=
vice *device)
>         /* Get the PCH current temperature value */
>         pch_cur_temp =3D GET_PCH_TEMP(WPT_TEMP_TSR & readw(ptd->hw_base +=
 WPT_TEMP));
>
> +       if (pch_cur_temp >=3D pch_thr_temp)
> +               dev_warn(&ptd->pdev->dev,
> +                       "CPU-PCH current temp [%dC] higher than the thres=
hold temp [%dC], S0ix might fail. Start cooling...\n",
> +                       pch_cur_temp, pch_thr_temp);
> +
>         /*
>          * If current PCH temperature is higher than configured PCH thres=
hold
>          * value, run some delay loop with sleep to let the current tempe=
rature
> --

Applied as 6.11 material, thanks!