Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp1269305lqt; Fri, 7 Jun 2024 12:59:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWVA6zX7vNlKQ3tMSCbDEs3x+f0RRsotGrIkvgeEvrLQs1tuZZydNeKyU37WddvrMdOsljvxHVR4kKV2/gdUyKveZMIH+T4DglBDTMeew== X-Google-Smtp-Source: AGHT+IEkoAB2S9/uEARCOblyGhDXufEtjd/cxGAtQHAjyQgvm+oNBtMv3fgg7tPUd2bi6GXxbYIH X-Received: by 2002:a2e:9990:0:b0:2ea:8291:c669 with SMTP id 38308e7fff4ca-2eadce86221mr21116851fa.44.1717790374450; Fri, 07 Jun 2024 12:59:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717790374; cv=pass; d=google.com; s=arc-20160816; b=Rvdwd7Wpb3iF0N/V8kkgWTAk351/7fJzSOwXJsR9mQ86eMzQS8aDlHjs+dC8nT6YPC BF1hIu9314e9oxJ+2vPVaJo2+JTnmfx6sLl16Iy8IgImMFeEncM7r1cPe1o3da51T2GP 7Bl3NUBgI1z4y0hnMx/lrrhRPX5YQui3EWIpKDT2iSFym+SP2+RF+iwwApasWUGgdvfI 1k53vxmcLhihjJWUQrlbo8tvJZWl9FrGlkvqZU/GKc/0s0r+j4rE89Tn39uNEj5RBZ1w pEX7BdDma4qt6NAAzcDey7jQX3KOrP4IJCuBZHqyV8vah0pVVl2QgtHMwPFrVah9JzSV t/hw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:subject:cc:to:from :date:dkim-signature; bh=UtYA5zapyBMoXmyW44lAPMM2LEo4wDioW7l5s/DUARc=; fh=T0Q3HcpJpjjreIvchP1/VzhWV8wf235rqW/y/zU4G7I=; b=SoN0U0+HevRXOy0DSsGNctCM2CMpkXA8cadhq2roYOJgjCoB2eHSg6NmYgQJyUmj/2 bPeS7F3ItZQ6e2HKK2WVo9SiFUdbzY6LPTXUGjt6/OJNsHqJmQXDKhhRVpz8Sq9n6rD3 kK1hvsKT1GSK7Bo32cnbTJgf6uU1DvMdpDUAQy3bFX4udli7PbrkJJb7qQW7pPLXW/co nSFUzaulGRl9WZQDAIpzFFiXUFe8NIV9hNPWdnRcAMbvwYzdOsNa+Z2RwEMNAxS3ye4I pKIuxsxbNYSlhUxolsk1Hf1yxBsG2pUXi8Kbqj0XWd7WI+vbp/zlyjaSA7lZ1kIONnoa Sqkg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PpZz0Fk1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-206684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206684-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57aae28bf67si2099242a12.630.2024.06.07.12.59.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 12:59:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-206684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PpZz0Fk1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-206684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206684-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 28C251F22E02 for ; Fri, 7 Jun 2024 19:59:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A814A14F127; Fri, 7 Jun 2024 19:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PpZz0Fk1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C509E39FFB; Fri, 7 Jun 2024 19:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717790358; cv=none; b=B3kzl9Psu6qoc73EqLoMVTgAx2tHnsytqROVtSYagM1L+k5phy9qMIqXvgVnKxeJ+jOvTjtPm57El6xLlF/kuFwuP03jMfTExAEVQGnu76si+WgF0SZMt/gN6NG/T5n9BKSFtlZdRiRbSZIXbGNvgif8jKc54R2ts8S0NMDRb2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717790358; c=relaxed/simple; bh=CoZ61dwjEkp8sx38CmXzgu042Gq6Y2RZI+poqBTGNRY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=JaQdw26TyXHYs9Fo/WDYBRupof8wXebjv3g1Ar0ptE6CmWJGMhFLOkwuJN4lxhbfnqQemWOWndrN+5g0QVSKi6cDE0fxBi1P5IAfxnzHDxHqaqK+2mKJ7mPWyCtaFyj1wHyLS2AEAU6Z6z+cqP9UrITkRIOxAmCnflomKcVKOu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PpZz0Fk1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 040A9C2BBFC; Fri, 7 Jun 2024 19:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717790358; bh=CoZ61dwjEkp8sx38CmXzgu042Gq6Y2RZI+poqBTGNRY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PpZz0Fk1qd29Dq/97R1hu02THlUUYJ1NFRfiFtIqZIf+WH3jdCae/0A+Fse0qdb2j eRLYBBDV3j9426bCf0RU+tpU7PffIXNJmkbdpiZV6JxkiHyJ+ZKaNmvEDeu+JHKzCf FvcLfAwdeau4erACKx4GOBy+wH+EElJmTzuqrd/Aw3KqT5+cFC/o7hiActdTMTWrb7 IEsTcusAgUicK7B7Q6VDyddEs7BM9mPGXHeH65t68T9MnX4G7hqyNMpy6RkE10ajiF gJoGhVDPUju3jZabZSWNMXt60KLJ4rqsF8EckGHBADnE/SA2UpgUbLItAkkAE73VGl mL3kKpxofY6Cg== Date: Fri, 7 Jun 2024 14:59:15 -0500 From: Bjorn Helgaas To: Wei Huang Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, bhelgaas@google.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, alex.williamson@redhat.com, gospo@broadcom.com, michael.chan@broadcom.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, andrew.gospodarek@broadcom.com, manoj.panicker2@amd.com, Eric.VanTassell@amd.com, vadim.fedorenko@linux.dev, horms@kernel.org, bagasdotme@gmail.com Subject: Re: [PATCH V2 3/9] PCI/TPH: Implement a command line option to disable TPH Message-ID: <20240607195915.GA852179@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531213841.3246055-4-wei.huang2@amd.com> On Fri, May 31, 2024 at 04:38:35PM -0500, Wei Huang wrote: > Provide a kernel option, with related helper functions, to completely > disable TPH so that no TPH headers are generated. If we need this option, say what the option is, why we need it, and include an example of how to use it in the commit log. Include the option in the subject line, too, e.g., "Add pci=notph option to disable TPH". Or maybe "prevent use of TPH"? "Disable TPH" hints that BIOS might have enabled it, and this option would turn that off. I haven't looked hard enough to know exactly what you intend or whether there's a difference.