Received-SPF: pass (google.com: domain of linux-kernel+bounces-206445-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 7 Jun 2024 17:02:06 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] f2fs: get rid of buffer_head use
Message-ID: <ZmMu_tnbqZtGJCsE@casper.infradead.org>
References: <20240607101829.389015-1-chao@kernel.org>
 <ZmMMDy9eeCU2igqj@casper.infradead.org>
 <e56b6166-1bb4-411a-a701-51bf452d2369@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e56b6166-1bb4-411a-a701-51bf452d2369@kernel.org>

On Fri, Jun 07, 2024 at 10:10:52PM +0800, Chao Yu wrote:
> On 2024/6/7 21:33, Matthew Wilcox wrote:
> > On Fri, Jun 07, 2024 at 06:18:29PM +0800, Chao Yu wrote:
> > > @@ -1990,6 +1989,12 @@ static inline struct f2fs_super_block *F2FS_RAW_SUPER(struct f2fs_sb_info *sbi)
> > >   	return (struct f2fs_super_block *)(sbi->raw_super);
> > >   }
> > > +static inline struct f2fs_super_block *F2FS_SUPER_BLOCK(struct folio *folio)
> > > +{
> > > +	return (struct f2fs_super_block *)(page_address(folio_page(folio, 0)) +
> > > +							F2FS_SUPER_OFFSET);
> > > +}
> > 
> > This assumes that the superblock is in the first page of the folio.
> > That's not necessarily guaranteed; let's say you have a 64KiB folio
> > that covers the start of the bdev.
> 
> Oh, I missed to add large folio support in this version.
> 
> For the case: page size is 4KiB, and folio size is 64KiB,
> read_mapping_folio(mapping, 0, NULL) and read_mapping_folio(mapping,
> 1, NULL) will return the same #0 folio, right?

That's right.  If you want to pass a page into F2FS_SUPER_BLOCK, that
would be fine.  Assuming you're not trying to support fs blocksize !=
PAGE_SIZE.