Received-SPF: pass (google.com: domain of linux-kernel+bounces-206711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Stephen Brennan <stephen.s.brennan@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
        Stephen Brennan <stephen.s.brennan@oracle.com>,
        "Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
        Omar Sandoval <osandov@osandov.com>,
        David Hildenbrand <david@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Hao Ge <gehao@kylinos.cn>, linux-debuggers@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v4] mm: convert page type macros to enum
Date: Fri,  7 Jun 2024 13:29:53 -0700
Message-ID: <20240607202954.1198180-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?YlN4k2MehHKBY/DDLpq/nCmKzeu1+acaMrgpAiwBllcAC2ScxSHDDZOpOiRw?=
 =?us-ascii?Q?Y96CdQMQRdEdckKGY+gm4WXuPoGkHmZpqaOzM9AcGUO1xBI9gBMiw03mrzfQ?=
 =?us-ascii?Q?ftqzYVHCOvMm5Io1CJKUjFloXrX4Zh/f89tVdCHEm82naA4NSQ3SHbX8yAne?=
 =?us-ascii?Q?BY9npUR+eWpMyoHXNmXReZsL5smpv7KUqtL2TuRNEdH2vPDrWRdBM/LF/TRf?=
 =?us-ascii?Q?8ixAj0UVTRcRj4e24nO6MKX/WjtlJvZzniB36n+3QhbW3Kemc1PCNYoscvtv?=
 =?us-ascii?Q?K/MUSEMva6vZZvnbJpL9IG6a0haU1+rXjwrehCQuKjsVWIbYq4EKpIqbRodo?=
 =?us-ascii?Q?y7P/0oveRWx2/jlVyF5AXa45F3zYtXB45vOBG8pJAGnWQqMGF65Nr+xcpWMa?=
 =?us-ascii?Q?DKX8O5IzSRUGLsF3+FXDdi+SE8G9s5u1Md3J4VzZ9D+IsAYETKbnNerv0Tlj?=
 =?us-ascii?Q?Wf3tr/wrvZtjvvy4X27a7kbK87ys6XqurX5UD0/bQYlBZM38nf0lHJrf26X9?=
 =?us-ascii?Q?ZwrDYL7gFwtNqAaaw5+gB2fL3O2NRhT1pYRT+icNDnIQmnguT0W102AqClWR?=
 =?us-ascii?Q?7STpxXSi6ASbXVCDAA/hooyQwDhf1ubtIwIeP+xeA+nzOx8Yw4Z1T/6JjZUp?=
 =?us-ascii?Q?9EySPeEhkPHuHjRWcF2kcQUgFPPt9RoqqtiUQRMexqXRrPAwB5rvV4HFNI+1?=
 =?us-ascii?Q?CI0xW2SM0psuOGAhLRK/6vIwPQJMdLvCS9LlZLEIEmez+L7HdC+AnbesA80X?=
 =?us-ascii?Q?xE1wLDNm3o8DUT0DTA3DASEebk4+WDNI4OZOpLbSZQnQASX51qsQpqCK372T?=
 =?us-ascii?Q?U1E2emmvEAOAMhhG28uhG5X7dSiTtutbgmvoy2Pauy5Thnvsq5corIhCGBSZ?=
 =?us-ascii?Q?r7DFVcqdxWBkbIn3MJjCwtv2zKmtIMtmAzx7JUsinsJdc/wtVXf2wZYTQPag?=
 =?us-ascii?Q?I3VETrulZ3TS8E/MzzInW42kkseSi6eC1Ycpe/i9qUn0M1A3Rcby28AccM/f?=
 =?us-ascii?Q?Smnr00+DFioTD3tyDY4d6K2s1R8STWDidV1obGT1wsSk/FRSUzk53NsNL2n+?=
 =?us-ascii?Q?jgZA4zZ44eT/OGSRNS/2Z0FF/CBfdtN++0lWLS4jBGor5GMtNrGZBTEPKwTJ?=
 =?us-ascii?Q?eThKKLb7d1bhFezImlX2GIUtMNvI1X9lFRT++TFeltvgCl4fh/Nn1imh0w1t?=
 =?us-ascii?Q?f8iCu5Uco/Hljp0Cnhq/hspb+X+iXjshlHtSPRd9IfMcLHT78vtvzt4hKidC?=
 =?us-ascii?Q?oLC44TdurBK7UCwZEL0CayWJ+rtnabQ7G/Rcc0n+Wu5/ENBzbCWlmrp0fRts?=
 =?us-ascii?Q?XZc7HJxekPw0epSGT3SPL87BvkB0ag/zz1huEFbSrTs3zogt/S/ydEh2Aw77?=
 =?us-ascii?Q?eoUDQT+xM9WtioOHabA7Rs9NU0Vfk+rs5n4pIDGXpFJjmUCpi17m/o6WzO/k?=
 =?us-ascii?Q?D0n7T+fKa5xkTzbvp5KGB9pHDmg4BnefKTbNu85yACsIhFStHzyFiCTXo5ZT?=
 =?us-ascii?Q?/gPi9T1a6qfmIHy7bagKCg+LhWLRQa+ETxRkk0XwYssDEF72m8adWXoKEkvg?=
 =?us-ascii?Q?zRxbtRBTr4nYbRw95lP08ss21H0tvmZqzIU1mcg/XXUBlPRXjbYmDZuym6Xa?=
 =?us-ascii?Q?5g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	1HwiAKX1f5/J2ZedtfJeGQZfDm25X3XJGjeQshpueyAYqTFozJS/zPqg9mxikcPdBp1y4GHxpcAkqihr9ZzMKvfTHV69p2Hp3nR7gEB2DCOfY0h/xBkvpZ1XPX/J5fS3SDoDa1m5SOPd39LO6kbVLDpU5iPbvSqh2QNDRSyukNJ27014H5XVEbFs7yFh66DdXqYSFjKZWUr+g5AgBYPtPmKCK05aimwGAzPjVuz+S7ZxzYXYMfwhn0Tp7rDrEFSZfaESvz1ddrPp1w+fPnwcYUfKt39ArRx+Ak0dsyh2aLM7LfWP5vt09LfM0QkNC3HydY/mRneMhU/DJOIaB/LH+9X0lkGr3cUNIs+HxmWabqbc4n6wlLGug3uhGvs7nvutwj1IVV/WBOFTMXyN2LsmljZiq+VbLzA8yiRbWB/hBiDZ3Pegx54eR0uTykUBP0llMPFb/Zhp6kCNwNq0ZGRcn4OjwbKTE3rZ7d4IvskZiUhzHlZFIRXeZIpt13SDCwMvphsvUDQWnCQhbmZJRjgHdlggam26LRyXk9CP+Rjq7qv7VQhaA6WpF9v9HJLuRXq3wxzD6V4yCGiWHv3rXjqtL+f2ri++IYXVxyWx1X1kryo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b20a55d-360e-45f6-89bf-08dc87309857
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6597.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 20:29:56.4779
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YsbekK4rUI4Y3U7feC2TFqqnaEGoOq7+wCJ4Z4gMUcUhYa1TD8lAe0BblVfJDgEu7C9yJMwMc/SQWBkkn9O9+nvuUtn+9pccPMFLam9+5lU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7251
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-07_12,2024-06-06_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406070151
X-Proofpoint-GUID: b8kITbBsEjvOOPsz0VKdrrl5Cjc1PjRL
X-Proofpoint-ORIG-GUID: b8kITbBsEjvOOPsz0VKdrrl5Cjc1PjRL

Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3
("mm: free up PG_slab") in has the unintended consequence of removing
the PG_slab constant from kernel debuginfo. The commit does add the
value to the vmcoreinfo note, which allows debuggers to find the value
without hardcoding it. However it's most flexible to continue
representing the constant with an enum. To that end, convert the page
type fields into an enum. Debuggers will now be able to detect that
PG_slab's type has changed from enum pageflags to enum pagetype.

Fixes: 46df8e73a4a3 ("mm: free up PG_slab")

Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
---
v3 -> v4: rename to enum pagetype, avoiding conflict in f2fs.h and matching
          the name of enum pageflags
v2 -> v3: rebase on mm-unstable
v1 -> v2: include PAGE_TYPE_BASE and PAGE_MAPCOUNT_RESERVE

 include/linux/page-flags.h | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index f04fea86324d9..32722c6e8397b 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -945,20 +945,23 @@ PAGEFLAG_FALSE(HasHWPoisoned, has_hwpoisoned)
  * mistaken for a page type value.
  */
 
-#define PAGE_TYPE_BASE	0x80000000
-/*
- * Reserve 0xffff0000 - 0xfffffffe to catch _mapcount underflows and
- * allow owners that set a type to reuse the lower 16 bit for their own
- * purposes.
- */
-#define PG_buddy	0x40000000
-#define PG_offline	0x20000000
-#define PG_table	0x10000000
-#define PG_guard	0x08000000
-#define PG_hugetlb	0x04000000
-#define PG_slab		0x02000000
-#define PG_zsmalloc	0x01000000
-#define PAGE_MAPCOUNT_RESERVE	(~0x0000ffff)
+enum pagetype {
+	/*
+	 * Reserve 0xffff0000 - 0xfffffffe to catch _mapcount underflows and
+	 * allow owners that set a type to reuse the lower 16 bit for their own
+	 * purposes.
+	 */
+	PG_buddy	= 0x40000000,
+	PG_offline	= 0x20000000,
+	PG_table	= 0x10000000,
+	PG_guard	= 0x08000000,
+	PG_hugetlb	= 0x04000000,
+	PG_slab		= 0x02000000,
+	PG_zsmalloc	= 0x01000000,
+
+	PAGE_TYPE_BASE	= 0x80000000,
+	PAGE_MAPCOUNT_RESERVE	= ~0x0000ffff,
+};
 
 #define PageType(page, flag)						\
 	((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE)
-- 
2.43.0