Received-SPF: pass (google.com: domain of linux-kernel+bounces-206788-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <b16316c9-67b8-4afa-af5c-6d3fb33c3c6f@linuxfoundation.org>
Date: Fri, 7 Jun 2024 15:55:46 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 07/10] selftests/pidfd: Fix wrong expectation
To: =?UTF-8?B?T2thbiBUw7xtw7xrbMO8?= <okantumukluu@gmail.com>,
 brauner@kernel.org
Cc: shuah@kernel.org, linux-kernel@vger.kernel.org,
 linux-kselftest@vger.kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?=
 <mic@digikod.net>, Kees Cook <keescook@chromium.org>,
 Shuah Khan <skhan@linuxfoundation.org>
References: <20240606180223.5527-1-okantumukluu@gmail.com>
Content-Language: en-US
From: Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20240606180223.5527-1-okantumukluu@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 6/6/24 12:02, Okan Tümüklü wrote:
> From: Mickaël Salaün <mic@digikod.net>
> 
> Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
> which will be actually tested on the parent and child sides with a
> following commit.
> 
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: Christian Brauner <brauner@kernel.org>
> Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
> Signed-off-by: Mickaël Salaün <mic@digikod.net>

FYI - This patch is already in the mainline.

commit 821bc4a8fd2454ff6d719aae7cac93f60567fe65
Author: Mickaël Salaün <mic@digikod.net>
Date:   Sat May 11 19:14:42 2024 +0200

     selftests/pidfd: Fix wrong expectation
     
     Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
     which will be actually tested on the parent and child sides with a
     following commit.
     
     Cc: Shuah Khan <skhan@linuxfoundation.org>
     Reviewed-by: Kees Cook <keescook@chromium.org>
     Reviewed-by: Christian Brauner <brauner@kernel.org>
     Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net
     Signed-off-by: Mickaël Salaün <mic@digikod.net>


thanks,
-- Shuah