Received-SPF: pass (google.com: domain of linux-kernel+bounces-206808-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <30d71968-d32d-4121-b221-d95a4cdfedb8@gmail.com>
Date: Sat, 8 Jun 2024 01:28:48 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 2/2] net: wwan: Fix SDX72 ping failure issue
To: Slark Xiao <slark_xiao@163.com>, loic.poulain@linaro.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 manivannan.sadhasivam@linaro.org
References: <20240607100309.453122-1-slark_xiao@163.com>
Content-Language: en-US
From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
In-Reply-To: <20240607100309.453122-1-slark_xiao@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello Slark,

without the first patch it is close to impossible to understand this 
one. Next time please send such tightly connected patches to both 
mailing lists.

On 07.06.2024 13:03, Slark Xiao wrote:
> For SDX72 MBIM device, it starts data mux id from 112 instead of 0.
> This would lead to device can't ping outside successfully.
> Also MBIM side would report "bad packet session (112)".
> So we add a link id default value for these SDX72 products which
> works in MBIM mode.
> 
> Signed-off-by: Slark Xiao <slark_xiao@163.com>

Since it a but fix, it needs a 'Fixes:' tag.

> ---
>   drivers/net/wwan/mhi_wwan_mbim.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
> index 3f72ae943b29..4ca5c845394b 100644
> --- a/drivers/net/wwan/mhi_wwan_mbim.c
> +++ b/drivers/net/wwan/mhi_wwan_mbim.c
> @@ -618,7 +618,8 @@ static int mhi_mbim_probe(struct mhi_device *mhi_dev, const struct mhi_device_id
>   	mbim->rx_queue_sz = mhi_get_free_desc_count(mhi_dev, DMA_FROM_DEVICE);
>   
>   	/* Register wwan link ops with MHI controller representing WWAN instance */
> -	return wwan_register_ops(&cntrl->mhi_dev->dev, &mhi_mbim_wwan_ops, mbim, 0);
> +	return wwan_register_ops(&cntrl->mhi_dev->dev, &mhi_mbim_wwan_ops, mbim,
> +		mhi_dev->mhi_cntrl->link_id ? mhi_dev->mhi_cntrl->link_id : 0);

Is it possible to drop the ternary operator and pass the link_id directly?

>   }
>   
>   static void mhi_mbim_remove(struct mhi_device *mhi_dev)