Received-SPF: pass (google.com: domain of linux-kernel+bounces-206816-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <948cd6bd-68d8-ca39-4ae7-d7d9b0460e5e@amd.com>
Date: Fri, 7 Jun 2024 17:35:16 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH] selftests/resctrl: Fix noncont_cat_run_test for AMD
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>, babu.moger@amd.com,
 fenghua.yu@intel.com, shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
 ilpo.jarvinen@linux.intel.com, maciej.wieczor-retman@intel.com,
 peternewman@google.com, eranian@google.com
References: <3a6c9dd9dc6bda6e2582db049bfe853cd836139f.1717622080.git.babu.moger@amd.com>
 <9a7213d2-a782-4342-93f2-acf191c745fd@intel.com>
 <3bd755d7-e5c7-3dc3-9875-4884c857e325@amd.com>
 <8553ddc2-ee0f-447d-8fe4-5a7dd84375f2@intel.com>
 <edc31538-3aa1-a35a-ea67-b13f626a84ec@amd.com>
 <2491e8da-8664-428f-87bd-40595af7af47@intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <2491e8da-8664-428f-87bd-40595af7af47@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mk0rUE5Oc3lrMGx5QjcyMDhZV3dpR2JZenRRV0xHOWVsdkVKRDRSVmZuWlRF?=
 =?utf-8?B?Z2dTOWlTQ1c2MXBiVXJEb001Y3B6aUkvbXpYZkJwb3NZME9lYkZxSDAyWjlv?=
 =?utf-8?B?dnc1UTRvREQrWVluMjJObloxWGs4MUJyNTY4YWVYV2JBaVM2K1B0WUpiblZl?=
 =?utf-8?B?WUFmSXBIOGJMakNtRndlQzJlOEx6TzJYTHFuZ1doUHV2NXRZdWQ1S0pTbVdG?=
 =?utf-8?B?VXJrUkZvRE03SUo3czlzTi9KV3VhbU0wK3dXOUExSG5uV1BLdm1ZMC9RWFg2?=
 =?utf-8?B?dUJReEVGZk1uLzFOVlVnWlVDRFo4b1ZXTW9XYVpKSlV0N2xxeUZnUlc2R0d3?=
 =?utf-8?B?amdlVjZUb2djTFRQNmZKVlYvQ0psU2E4WTBKRlZELzRGL201REdTRjB1ZmRP?=
 =?utf-8?B?S1k3VGRGSExFVVFOaGtVNVNNSUZmZWQ4eGpUZ0h5RUk2cE0yZW5hV1htRkZ0?=
 =?utf-8?B?b3ZjT0RERUlvM0ZiTWUwbDM3dDJlb2pyQkg2TEZBUUQyb1lVUEFuZmR6azY1?=
 =?utf-8?B?RG5FWHgzU0xxTXpyYVI2OEg2c3phNUlTZFdjb2MzS0JkL3A5SVFveDRHWDlk?=
 =?utf-8?B?VGlFVUFBU2hGTFZXcVVsbDg5L0dYVzBVdlc0NFBPcEVFQ09rR05rNlljR1Nn?=
 =?utf-8?B?bitHTFNOcWdENnIrcVMreSsxb1AvZndSeG9lSHlEMHNHaEwvRHN6cHFld3M5?=
 =?utf-8?B?RGlGVXNLTU9CK0c0V1M4MHJqQzdSYWVTQVFERTc4Z21uNWUyTFlrUmROUFBp?=
 =?utf-8?B?QXRwZ1RHd2dwNGdYN2NKRjdobnlXcDJtQkhKYkU5WGwzTElhNE54aDkxUHky?=
 =?utf-8?B?a0kvRHN0RWpjUmFISDdjWW11TmpIRnh6VHZUaHNvUCtLa3RQUTQ4KzZaL3ll?=
 =?utf-8?B?Ti85SllVZU13Qkg4aEZvekFGMDdBQ2V5RGpzbmNESHFZTXFKWXNGN0NWYURa?=
 =?utf-8?B?d3FsQTFoeGxGcFRjekJGU0ZKRTdVK1ArQldrcGpKSUpUVURkcXViS2lZQUhm?=
 =?utf-8?B?SU1KMXhtTitsY3FxN2MwdzNiQnBySkc0ZEVCakhwRVdEektqVDlRVEVYWm9j?=
 =?utf-8?B?WlM3akJVcDlvemllaXdTbDZIdytZMzI4alFLL0xjTGlKVGpMSzJWRE4zTXkx?=
 =?utf-8?B?TTJjZ3BXeTRwMnN1UVFBTzF3VDN5bUZka2NFOVhQdmNLTmFVdlFkK09rTlBK?=
 =?utf-8?B?M0wxWEx0ZWVQYXg1REFWM3lFU2RjeERwcUc3SkV4YmNsY241Tml6a0NTR2Y0?=
 =?utf-8?B?djJIaHN0aHZDbGxwYk8zN2V6Z050OFRHRUZUZ0dHOG55aGdrQ3FGeWZ4akNq?=
 =?utf-8?B?WGZVOGpsQ1pjSWRoZTlnNTgwTXV3YWF1YjBjbmpadlZkSzY2Z0R3VXY0UGlq?=
 =?utf-8?B?OERaSUcvWmdiR1UydnhBK0w3RmJPZXJFRU12Q2tIRW9sNVZLdGI4akxLZS9R?=
 =?utf-8?B?amNjSVk4TXp5SitZNWFjZ2FaZnNqNjRZYzR2VkFLWkNMd0tZNWIzUnVQNnZw?=
 =?utf-8?B?dFo0ZUF3K2NXaDd0Q0JyRW1rR0IyeWQvVTJjK3ZxVmVXMmE3OXFFU2d6c3d6?=
 =?utf-8?B?Tk56NDA0TjdrMUE0UEhzNEpHS3lNMFFGajl1ZXBWRXhxSkhMYStic1BRRm1O?=
 =?utf-8?B?ZkJlUDNGWkdRNU9TeEM2VU1WQkVicEc2QnFONGRJY0ltMVN4UVNNbVdPT1Ay?=
 =?utf-8?B?YkFvRTJUT2FReWk0Yjg4MHVraXVqdDEyL00wWWF6cWxJYjczVjM2bG1yZm52?=
 =?utf-8?B?RjhwUEd3Wms0ZmtBNytyNmk2OXJXVVNWek9YSC8zWmgyZlFTaEJBc21kam1u?=
 =?utf-8?B?aXBxSm15UzBCb1ZzWjJsM2dlbjk4NXdxQ2RFekFtTGlMa2MvOVQ5L2pDbUY4?=
 =?utf-8?B?aE5DVGNOQnZnMHc1bVg0aGZRSHF2Q0NWNzZ5cmFsMm1INWJpRnU1YnJEOXR6?=
 =?utf-8?B?TlVFSFlsV2F5NmZBZVg2VkdnQ3M4a25OKzBKaitHTmJoT2FuT0N0Z3dFY2Ju?=
 =?utf-8?B?UVBGRlp6elg2N0dEMnFmaUFzbHhPcVdTTUQwbS9PUkF4Z0RRRkdaR1F5UTFD?=
 =?utf-8?B?VTh4dEFBVVprejZMMWpWalZYbUJURU5ObXFFY0VYK0d1Sm5nSzREbHBtZ3ox?=
 =?utf-8?Q?3pWyJeXwJizzp/GNobiSYHkOY?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04a3a134-9487-44d7-4777-08dc87421cbb
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 22:35:20.0429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ve87gPYsysHZ2mvE1bif8T9WoBmw1H+nY8W8SNO2Unajd/EqSSdbSlHBOT94+GD8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7275

Hi Reinette,

On 6/7/2024 4:47 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 6/7/24 11:16 AM, Moger, Babu wrote:
>> On 6/6/2024 6:58 PM, Reinette Chatre wrote:
>>> On 6/6/24 4:09 PM, Moger, Babu wrote:
> 
>>>> @@ -301,15 +320,8 @@ static int noncont_cat_run_test(const struct 
>>>> resctrl_test *test,
>>>>          if (ret)
>>>>                  return ret;
>>>>
>>>> -       if (!strcmp(test->resource, "L3"))
>>>> -               __cpuid_count(0x10, 1, eax, ebx, ecx, edx);
>>>> -       else if (!strcmp(test->resource, "L2"))
>>>> -               __cpuid_count(0x10, 2, eax, ebx, ecx, edx);
>>>> -       else
>>>> -               return -EINVAL;
>>>> -
>>>> -       if (sparse_masks != ((ecx >> 3) & 1)) {
>>>> -               ksft_print_msg("CPUID output doesn't match 
>>>> 'sparse_masks' file content!\n");
>>>> +       if (!(arch_supports_noncont_cat(test) && sparse_masks)) {
>>>> +               ksft_print_msg("Hardware does not support 
>>>> non-contiguous CBM!\n");
>>>
>>> Please fix the test as well as the message. It is not an error if 
>>> hardware does
>>> not support non-contiguous CBM. It is an error if the hardware and 
>>> kernel disagrees whether
>>> non-contiguous CBM is supported.
>>
>> Not sure about this comment.
>>
>> Did you mean?
>>
>>   if (!arch_supports_noncont_cat(test)) {
>>                  ksft_print_msg("Hardware does not support 
>> non-contiguous CBM!\n");
>>                  return 0;
> 
> The above changes whether support for non-contiguous CBM is treated as 
> an error but the
> test should still proceed since the test goes on to write different CBM 
> to the system
> and verifies results are as expected based on what hardware supports.
> 
>>           } else if (arch_supports_noncont_cat(test) && !sparse_masks)) {
>>                  ksft_print_msg("Hardware and kernel support for 
>> non-contiguous CBM does not match!\n");
>>                  return 1;
> 
> I can see how this will work for AMD for the scenario being checked but 
> not for
> the different Intel variants.
> 
> I think this can all be simplified with something like:
>      if (arch_supports_noncont_cat(test) != sparse_masks)) {
>          ksft_print_msg("Hardware and kernel differ on non-contiguous 
> CBM support!\n");
>          return 1;
>      }
> 
> I modified the message slightly since non-contiguous CBM does not 
> actually require kernel
> support.
> 
> What do you think?

Yes. That is fine.
Thank you
- Babu Moger