Received-SPF: pass (google.com: domain of linux-kernel+bounces-206902-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Tommy Huang <tommy_huang@aspeedtech.com>
To: Andi Shyti <andi.shyti@kernel.org>
CC: "brendan.higgins@linux.dev" <brendan.higgins@linux.dev>,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>, "joel@jms.id.au"
	<joel@jms.id.au>, "andrew@codeconstruct.com.au"
	<andrew@codeconstruct.com.au>, "wsa@kernel.org" <wsa@kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org"
	<linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH] i2c: aspeed: Update the stop sw state when the bus
 recovry occurs
Thread-Topic: [PATCH] i2c: aspeed: Update the stop sw state when the bus
 recovry occurs
Thread-Index: AQHasl/7kNWQnBw5T0ayJZ/33ciwnbG5/HuAgANZ04A=
Date: Sat, 8 Jun 2024 04:38:19 +0000
Message-ID:
 <TYZPR06MB6191C0769400FF03412E56F2E1C42@TYZPR06MB6191.apcprd06.prod.outlook.com>
References: <20240530070656.3841066-1-tommy_huang@aspeedtech.com>
 <kts7ib2rxq4g26ayumcyaohs37zl43qo66gok3vae3reyabobe@nbbborkf2eow>
In-Reply-To: <kts7ib2rxq4g26ayumcyaohs37zl43qo66gok3vae3reyabobe@nbbborkf2eow>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?/tVS47iWDPxOg77osJS7HBL49oFgoxKCIFOKgVDCw0HEBuu2DsBP34Zu8RPN?=
 =?us-ascii?Q?ZgNy5S4NWhELpqcQh6hPdKqI34ncAg3zzhmzcVxM/lwHcxQMmAUSe4tJpZbz?=
 =?us-ascii?Q?wudwh/q6c06F+FfE552s5K44EKQilUdaaZorOVrRWw1sNCLCqO1wNUPbYoEK?=
 =?us-ascii?Q?ZkXaj/m/jWpUnS7qzlC8PHivzxXFSQ6fkiIdTSijHm06JpMiNejcTmIz9cMw?=
 =?us-ascii?Q?dSHljF4m4I7Xa6GB9TQt3gZsiroDGlZMRJYilh7t7uS4YueY6ZhwWY48NFa5?=
 =?us-ascii?Q?Tl/8SDemEt0iSHkkZ+39xIqBu/qmlGOwh+E7+1D2T5xK7Es/wH2o1c8u7vn/?=
 =?us-ascii?Q?ZrLSxYbbUDfHE0Rtj5YtLY1hJV5vgRkNPbsAB2m0yZCRNy/INaCurAPtLf/l?=
 =?us-ascii?Q?/Mx8OMduDNjwrg3ptYXDqPjVMsuoLcIV3kXi372XC+36U9iRkWC3BCSEf4Xz?=
 =?us-ascii?Q?GRcpiTxZs6qborvyn7HSXEMoutrDQEpfU5XYhs9vraKKTwCqz7ZzZ1tk/9yF?=
 =?us-ascii?Q?M829rarzVzBKEgC4T6xY4twYRCERRey7ajhoHs6mhfzMycltsIZ+la4DEG4D?=
 =?us-ascii?Q?z3IiTv6G2OP48misNLbCJnWsGrRqZcsdtFK0eITMAZhY++jlHXXzZbcIB2Jz?=
 =?us-ascii?Q?mN138qRv7KL7WwgRQyIbxtDwvrVI1gMwtDlqJOL96QEev9UZqSf7UlQLGsmY?=
 =?us-ascii?Q?qgVR1rQz9ItoA+t3Zr7ofiuuiV8piLIpafwXwKYtu92gfwvssIp01poCwwYv?=
 =?us-ascii?Q?Th9HHN3RVHBtguRdsVrMwCgdqpeDUu92BMbOkVktw+3Z4xAwfu/neoQZW8Ay?=
 =?us-ascii?Q?ftBE+iFQMa/kgxS4HvD8zkWSXw1FDvW9YbbkzY1LVcFyD0fRwsBUA4clwRyp?=
 =?us-ascii?Q?WBR0DJldbs7WoqgRTv0lWkN73QIRIGm0zvvkGaC7g61TpWSKe3tmIQkH+7Z8?=
 =?us-ascii?Q?9+zjcWZcy2b5+yJZVQo7N5E8R5YXi2E+jZqvR8T0vSEn2k8MLWaad+/XTq05?=
 =?us-ascii?Q?wN5x9/oqyajLMdpFHfFwfxh18lTrkYwnvyLa3vHeGsdnuz2Ix0WjRXIcHCTY?=
 =?us-ascii?Q?ZKCNZpIdXKTmkiUqvjkG9oYDtr7B5DpsxfLhyJCZ4YsH1T1FrGY5f8VaOLzp?=
 =?us-ascii?Q?xH1S1mWRQgSxTeerc9lE6J2d73uS/jL6Yc0cISn6vi5Ukcy/8Cgzc844seQc?=
 =?us-ascii?Q?IP+I7suQXBh9col5N65EebLQ9GDemyWGm21HekAUA06ZB7Q1loTsZkJ7KXfi?=
 =?us-ascii?Q?rz9DAUwfx8V0HWGFV6VNgU+NqlUM43wASDQb/OdFxb0xVu8PSRi0N+ihDGYg?=
 =?us-ascii?Q?nG2LAMr88DH4R7aSkOv5TH4KhVzBFo1gIDRpvjpZmZ4vJGMkOjhZ5Sh/qPIb?=
 =?us-ascii?Q?ffEid4WWJyLgzTo3XnKnpfHV412/uCNz8435YfQMxGyVf7pSlFhtwgyVLFY9?=
 =?us-ascii?Q?LAoIIH0xQ78tUQLNFW68Doa9RAIBk1eWdYNAx5svj8F7rA3QaB8ySH9daftE?=
 =?us-ascii?Q?8lK9LirmFPhYblaB25Rphgc8gFpt+TdUVDAPnkjdW504X8lZbIh+y24IhdyT?=
 =?us-ascii?Q?4BCCc6rOT3wSKvbU88jxnCyNdGaYX8qoxhC81rwia/b9GnpBfR1imA9zx0jk?=
 =?us-ascii?Q?Gg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6191.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d95ac98-6c82-41af-4c75-08dc8774d23a
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2024 04:38:19.2720
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AMLelnFT+purG6DZkxjRKt0zNDtU1EWy9hX87ka1O2MGYBGlP86VKB1uDc7VvlJETpXL/yottnNiVyc+g9zMqkevgi0pTn1rHUyVSl7uRDg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6934

Hi Andi,

> -----Original Message-----
> From: Andi Shyti <andi.shyti@kernel.org>
> Sent: Thursday, June 6, 2024 9:27 AM
> To: Tommy Huang <tommy_huang@aspeedtech.com>
> Cc: brendan.higgins@linux.dev; benh@kernel.crashing.org; joel@jms.id.au;
> andrew@codeconstruct.com.au; wsa@kernel.org; linux-i2c@vger.kernel.org;
> openbmc@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; BMC-SW
> <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH] i2c: aspeed: Update the stop sw state when the bus
> recovry occurs
>=20
> Hi Tommy,
>=20
> On Thu, May 30, 2024 at 03:06:56PM +0800, Tommy Huang wrote:
> > When the i2c bus recovey occurs, driver will send i2c stop command in
> > the scl low condition. In this case the sw state will still keep
> > original situation. Under multi-master usage, i2c bus recovery will be
> > called when i2c transfer timeout occurs. Update the stop command
> > calling with aspeed_i2c_do_stop function to update master_state.
> >
> > Fixes: f327c686d3ba ("i2c: aspeed: added driver for Aspeed I2C")
> >
> > Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
>=20
> Can you please add:
>=20
> Cc: <stable@vger.kernel.org> # v4.13+

Got it. I will add it.

>=20
> > ---
> >  drivers/i2c/busses/i2c-aspeed.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-aspeed.c
> > b/drivers/i2c/busses/i2c-aspeed.c index ce8c4846b7fa..32f8b0c1c174
> > 100644
> > --- a/drivers/i2c/busses/i2c-aspeed.c
> > +++ b/drivers/i2c/busses/i2c-aspeed.c
> > @@ -169,6 +169,7 @@ struct aspeed_i2c_bus {  };
> >
> >  static int aspeed_i2c_reset(struct aspeed_i2c_bus *bus);
> > +static void aspeed_i2c_do_stop(struct aspeed_i2c_bus *bus);
>=20
> Can you please move aspeed_i2c_do_stop() on top? Doesn't make much sense
> to add the prototype here as there is no dependencies.

Sure. I will update it.

>=20
> It's different the case of aspeed_i2c_reset() because it needs aspeed_i2c=
_init().
>=20
> >  static int aspeed_i2c_recover_bus(struct aspeed_i2c_bus *bus)  { @@
> > -187,7 +188,7 @@ static int aspeed_i2c_recover_bus(struct aspeed_i2c_bu=
s
> *bus)
> >  			command);
> >
> >  		reinit_completion(&bus->cmd_complete);
> > -		writel(ASPEED_I2CD_M_STOP_CMD, bus->base +
> ASPEED_I2C_CMD_REG);
> > +		aspeed_i2c_do_stop(bus);
>=20
> The patch is good, though!
>=20

Thanks for your commects.

> Thanks,
> Andi