Received-SPF: pass (google.com: domain of linux-kernel+bounces-206893-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <b23fadac815f137ad93fa3bb90149e52956b3c62.camel@linux.intel.com>
Subject: Re: [PATCH V3 1/3] platform/x86/intel/sdsi: Add ioctl SPDM transport
From: "David E. Box" <david.e.box@linux.intel.com>
Reply-To: david.e.box@linux.intel.com
To: Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: linux-doc@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>, LKML
	 <linux-kernel@vger.kernel.org>, platform-driver-x86@vger.kernel.org
Date: Fri, 07 Jun 2024 20:44:47 -0700
In-Reply-To: <b32cd809-7aed-62ed-1b6e-550221a3acbb@linux.intel.com>
References: <20240606011617.557264-1-david.e.box@linux.intel.com>
	 <b32cd809-7aed-62ed-1b6e-550221a3acbb@linux.intel.com>
Organization: David E. Box
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-06-07 at 16:14 +0300, Ilpo J=C3=A4rvinen wrote:
> On Wed, 5 Jun 2024, David E. Box wrote:
>=20
> > Intel On Demand adds attestation and firmware measurement retrieval
> > services through use of the protocols defined the Security Protocols an=
d
> > Data Measurement (SPDM) specification. SPDM messages exchanges are used=
 to
> > authenticate On Demand hardware and to retrieve signed measurements of =
the
> > NVRAM state used to track feature provisioning and the NVRAM state used=
 for
> > metering services. These allow software to verify the authenticity of t=
he
> > On Demand hardware as well as the integrity of the reported silicon
> > configuration.
> >=20
> > Add an ioctl interface for sending SPDM messages through the On Demand
> > mailbox. Provides commands to get a list of SPDM enabled devices, get t=
he
> > message size limits for SPDM Requesters and Responders, and perform an =
SPDM
> > message exchange.
> >=20
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > Link:
> > https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_1.=
0.1.pdf
> > =C2=A0[1]
> > ---
>=20
> > +static int sdsi_spdm_do_command(struct sdsi_priv *priv,
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct sdsi_spdm_command __user *=
argp)
> > +{
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u32 req_size, rsp_size;
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (get_user(req_size, &argp=
->size))
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0return -EFAULT;
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (req_size < 4 || req_size=
 > sizeof(struct sdsi_spdm_message))
>=20
> Hi David,
>=20
> Is that 4 actually SPDM_HEADER_SIZE?
>=20
> If my guess is correct, no need to send an updated version, I'll just fix=
=20
> it while applying.

It is SPDM_HEADER_SIZE but I already fixed it in V4 since I had to address =
an
LKP report.

David

>=20
>=20