Received-SPF: pass (google.com: domain of linux-kernel+bounces-206951-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 8 Jun 2024 09:41:28 +0100
From: Simon Horman <horms@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	David Ahern <dsahern@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, sbhatta@marvell.com,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] ip_tunnel: Move stats allocation to core
Message-ID: <20240608084128.GJ27689@kernel.org>
References: <20240607084420.3932875-1-leitao@debian.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240607084420.3932875-1-leitao@debian.org>

On Fri, Jun 07, 2024 at 01:44:19AM -0700, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core instead
> of this driver.
> 
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
> 
> Move ip_tunnel driver to leverage the core allocation.
> 
> All the ip_tunnel_init() users call ip_tunnel_init() as part of their
> .ndo_init callback. The .ndo_init callback is called before the stats
> allocation in netdev_register(), thus, the allocation will happen before
> the netdev is visible.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Simon Horman <horms@kernel.org>