Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp1547309lqt; Sat, 8 Jun 2024 02:58:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXLJ5Gc0jn5m5IT73TyoQ4t+GhXuy1B/y+zBAT23RSKVXy3oNHd4ChLI2ZMYlHAZWwkRWxw/sroJWXfhUKVoCTq3gg7UGUmnPl4tpwWQQ== X-Google-Smtp-Source: AGHT+IGZ9Nq1fAZxeYuJryZYTn++EbH+irywShBPuOZwFQJLt25fdlRHB78PIN/2Z4ZllBBQd4U3 X-Received: by 2002:a05:6214:424d:b0:6b0:5aa6:9996 with SMTP id 6a1803df08f44-6b05aa6999amr40193936d6.24.1717840729093; Sat, 08 Jun 2024 02:58:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717840729; cv=pass; d=google.com; s=arc-20160816; b=A49gSNHrYwtG/++zb4ajKuUrm1Ma24cr/XyRhJhuZm+fwfNeqdG+JB7i3i3s5sB9Ar rf22ZiswmHN6MXWELIU10nI5XnO6dB4t4dO0NhzvkEwL0oJMjYxWg4pIM/A4UWkqtKYU RH5uRmSBPuWGkl+ajVFVvCRasq6aVqGdVaKQV9kgAgfnu01QiImMKTK4gvHlZSD8sKg3 FwVEIy6vw8VJRW8140I5Uu/5JhU7FgpBWtnz3WvZIsoOYCIivM6UYxl1mSQ5zgQGKxaW FJWc+snkTlIjdltll3JkT6016i2Ts965KgG4/CJkkBVa7R+HfWHxbDb2V+qgBxGuHw5z 8UrQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:date:from; bh=u4G75RBik6q1dVXuKCYDLFIHsG6e7U3snONYetEH2vg=; fh=utfQjCkRahwr7cibaYmIJMwet5QEVICWGR1rhV9cjSw=; b=sGyUYFIE9SSmYdxLJ5c3tDhT5AdODdtdvNdCVjId4ha202Yg89n8nKZMEpPAiBAOpk 1IHHNkFVmovHCOuRQSn5XA9Beayni5OQeLW2sFRcjZjKS6R6ttU5yd1dVmkweOexN3ua pVaMLZ4yUF2sWflHr3SbUfOpHM5j3x4caSaS9GPSTT6+Z+UW/j9cciNNJuaFUpRg+VfT WZzejrxaBN/2kBSMM3atp9uexMp3kEnV9ppUzcIVemKQfiRaNs5xx2aljxpyqfhEpTwW rVBuaijIeFnvH6ji8hfLj7WeaOTze9DGz1PmP5IVJ09tQdQr+Fhzyd5WDcS/2p/Ks3Iv xnQA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-207006-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207006-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6b069fb45b3si12094976d6.602.2024.06.08.02.58.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jun 2024 02:58:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207006-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-207006-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207006-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7801D1C20B19 for ; Sat, 8 Jun 2024 09:58:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83D4B178365; Sat, 8 Jun 2024 09:58:42 +0000 (UTC) Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BEC11779A4 for ; Sat, 8 Jun 2024 09:58:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.82 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717840722; cv=none; b=noo71OhNMJJb23lNs6R9MwPiMElZtefN5MT7XygcKAQX9qFjKK5Fy/FW4GxONT8uuz3GtX3x6CiECrfbE/h9JgP6W0h4uiLXxDlbG5X0lzpk4eMOWM3dzQpnJApmiFCMaRoUnYvZybGqfiDrvyertBu9bQZJIUd1/ntpCqVLCcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717840722; c=relaxed/simple; bh=zR7u7bpINGdctpqlmk9CTOIvqrr3eyoVr9BUEGTTrGM=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OECHlI6FybHQLpP9DhIrm1E5NECXOI5w7Tj8RRjBM/fQPrTgyCp2sNjls433DpKVGgHzh0T7JueIE0U6Cbn+TvALI5W3VWyLkSQ+PWUV2oFJl7s2ubStd6RET+MyIcW7vNrt05LNyUQxOWf/XQsdESe++XQS51BzKu7mIyNIMXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-26-230.elisa-laajakaista.fi [88.113.26.230]) by fgw23.mail.saunalahti.fi (Halon) with ESMTP id ad6f8b07-257d-11ef-80e2-005056bdfda7; Sat, 08 Jun 2024 12:58:38 +0300 (EEST) From: Andy Shevchenko Date: Sat, 8 Jun 2024 12:58:38 +0300 To: Crescent Hsieh Cc: Jiri Slaby , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 1/6] tty: serial: 8250: Fix the amount of ports doesn't match the device Message-ID: References: <20240607114336.4496-1-crescentcy.hsieh@moxa.com> <20240607114336.4496-2-crescentcy.hsieh@moxa.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607114336.4496-2-crescentcy.hsieh@moxa.com> Fri, Jun 07, 2024 at 07:43:31PM +0800, Crescent Hsieh kirjoitti: > Normally, the amount of ports is written at the third digit of device ID > of Moxa PCI boards, for example: `0x1121` indicates a 2 ports device. > > However, `CP116E_A_A` and `CP116E_A_B` are two exceptions, which has 8 > ports but the third digit of device ID is `6`. > > This patch fixes the issue above by adding checks. Can you send this patch separately and add Fixes tag? I will give my tag on it, but the rest needs some additional work I think. -- With Best Regards, Andy Shevchenko