Received-SPF: pass (google.com: domain of linux-kernel+bounces-207009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Erick Archer <erick.archer@outlook.com>
To: Daniele Venzano <venza@brownhat.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Justin Stitt <justinstitt@google.com>
Cc: Erick Archer <erick.archer@outlook.com>,
	netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH] ethernet: sis900: use sizeof(*pointer) instead of sizeof(type)
Date: Sat,  8 Jun 2024 12:20:33 +0200
Message-ID:
 <AS8PR02MB7237F187447FF71AE515333B8BC42@AS8PR02MB7237.eurprd02.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AS8PR02MB7237:EE_|DU0PR02MB9612:EE_
X-MS-Office365-Filtering-Correlation-Id: 0b8bf23b-92cc-4681-e32c-08dc87a4aab8
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|440099019|3412199016|1710799017;
X-Microsoft-Antispam-Message-Info:
	Yxm+GzbSGMfG0mquHWs5F2k/u4uUC51sgjREGDmOJP1Cip07NtFIEkWEksrLpNEmJ/ptPnszVR8t6FgMfYQABxGzdPfgT2phsD3NMTjC5XAXlKupuIqyNM/LFjqU1ylfAEO2AUy4xPelKtCkcVgi2DOqUAI8DfeNg+1+DNWRgI75241j4jTz36as5IODPE+ZlCYZsSUcZOpJ2sAzhEHnlXicXetafT+Ayzj5hhTC1RaP58Foa3WuaY+0DZ14a9aJ8uBvkP7ssIKncJReLJV6z2SBd/UIEoTccDJFU1XFtoD2r+26W+pMReseW/KIXj6gs1VvbvSK9zgRrLj+cfcl98StGvZE7Jcl/cgDlcCCPMK7PHvsqRawe1Ow4ritfGPmSK6bU7sBjb6ameNDwRFLwTsKE4GLzkBwpsQnRd7gwBAgNWnFC+on/AzqNko2DkmGZ4ghLaTtA5R/AHLb32E7RgsvwX2p423FdIMzDS/6gPY/54sUUQGoH0pVGOOTa/xqmouJ9BvE8RcZaQ9sQ3ic6j6euLvIYl5FtF83uAxwmpCQnmn33AX7T4cpuLCT7/76jVWBr/2qAFjrDRaUHHTaweuX+FWMgWsB58kGjF4EdKw=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?S45kq9AvTdCGTciVXKr7baLfkWO5aX3N7lW+dadllnXrwbxKIOzJOv/+odto?=
 =?us-ascii?Q?ihYiUyuMDe4H8/MAzOy3Xy1TnHqteuWzW55PRULkVeqwa4/+J4Dqk6XBX+8T?=
 =?us-ascii?Q?xifFIKxpw/LOYTNtHIC8OSrSnNFC5ER+yokKuX8QUGvrfcty2ALH4xnRXMQ0?=
 =?us-ascii?Q?52Uf6OMScOXKHNzlWGfjHGov5N7vCe5I2N/wpurDtMq8D7Uzbn9fWBnyYD9E?=
 =?us-ascii?Q?447HF4mueKmu7fIFRwlsKYTqNRNw+jTwo9u3fCFdjghQTGeAf8DsqLxRvnto?=
 =?us-ascii?Q?cue69ceHZnQigR0dSTG0CUSUwgQkldfZN7171NpsnVqNl0+jemXDVsO+zQ3/?=
 =?us-ascii?Q?rVbPwLTAiHPMg4Uq+TPZyRwhMFDSbY60cBb5wXlt88cKQst+8C7w14grC8C8?=
 =?us-ascii?Q?it2j8b7dGdOnguWdOpeIkBozP6bZQ8ZET2fiqkZrz+GmH5ALODFuUB3MicIt?=
 =?us-ascii?Q?EoKyBxMejSRM6x+Lsuxo6FjiUIO4J1Pguu1abuqSn/ABP+gbrEaXiTqjRuRi?=
 =?us-ascii?Q?n0G+xHffSYLl6ctmP/ruSN8XjQm3Q78ShzmRv2Y6AomIyoMPdElcPW1x+nOE?=
 =?us-ascii?Q?RvyzGzFBWabKekmaDRMJ+8MrnxugM+AZjZnMb2ItDmZsokiSNU6Z/spD987a?=
 =?us-ascii?Q?LHgMyVLpX7ma1ZgdUasPLULHEgfKhSwZTrhYTM9p5ji6zTvJRCKAR0+9luMW?=
 =?us-ascii?Q?5/JLRG6f5UAmyuejrTQaTw1wvfoUZhyJ3BeEkmhPQkG16YlfO5P6S1VOawK/?=
 =?us-ascii?Q?Dn2UCLRx9gKZCKGm2+ZJmMcTaZeZmMfxcOhsaDx8p3NinBMuxif3Jhp5/8RX?=
 =?us-ascii?Q?O4IziNvGIOp4K3eMB52xTqzv6z0lEQfILkl41v8tojgzcLxteJnrQhisUisA?=
 =?us-ascii?Q?L411aCHcDYnRFIhpc5EvFh/DxhJSrU+sixuR0mW5mk+kf9OcmII5iFGeF/M5?=
 =?us-ascii?Q?9yHpDpNi9OAuUQ7P1setmH9YF7/2urQuw+1GZ/p6C10itWTy+meGx64XN+PD?=
 =?us-ascii?Q?L/ZRx9sGy5ZTKe6dc4bbwRk8d66euiZO9hc4i8/lbj+2Vzi1fLiNMD88MoWo?=
 =?us-ascii?Q?Fq16Mu3Ts7Cc5+StTNTvAb6wjh2BxcaSMV8q7IWi8cI7DYOtZy2czYB6nNwh?=
 =?us-ascii?Q?JS3GW5MXctvMDGHIVsQOokYOYpvRVbbHEtfxppxuM0uEN/faK/iHStzugu1I?=
 =?us-ascii?Q?2x7SsX9+/Cpue1x5IgblcVE6wyPc17QHotcL0WoewgLcpnn1GDBhmTUDxFJ7?=
 =?us-ascii?Q?yWb24dyudjvBdbsCTcrD?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b8bf23b-92cc-4681-e32c-08dc87a4aab8
X-MS-Exchange-CrossTenant-AuthSource: AS8PR02MB7237.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2024 10:20:49.0575
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR02MB9612

It is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not
change the former (unlike the latter).

At the same time remove some unnecessary initializations and
refactor a bit to make the code clearer.

This patch has no effect on runtime behavior.

Signed-off-by: Erick Archer <erick.archer@outlook.com>
---
 drivers/net/ethernet/sis/sis900.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
index 85b850372efe..5b82c4763de9 100644
--- a/drivers/net/ethernet/sis/sis900.c
+++ b/drivers/net/ethernet/sis/sis900.c
@@ -614,11 +614,10 @@ static int sis900_mii_probe(struct net_device *net_dev)
 
 	/* search for total of 32 possible mii phy addresses */
 	for (phy_addr = 0; phy_addr < 32; phy_addr++) {
-		struct mii_phy * mii_phy = NULL;
+		struct mii_phy *mii_phy;
 		u16 mii_status;
 		int i;
 
-		mii_phy = NULL;
 		for(i = 0; i < 2; i++)
 			mii_status = mdio_read(net_dev, phy_addr, MII_STATUS);
 
@@ -630,7 +629,8 @@ static int sis900_mii_probe(struct net_device *net_dev)
 			continue;
 		}
 
-		if ((mii_phy = kmalloc(sizeof(struct mii_phy), GFP_KERNEL)) == NULL) {
+		mii_phy = kmalloc(sizeof(*mii_phy), GFP_KERNEL);
+		if (!mii_phy) {
 			mii_phy = sis_priv->first_mii;
 			while (mii_phy) {
 				struct mii_phy *phy;
-- 
2.25.1