Received: by 2002:ab2:68c1:0:b0:1fd:9a81:d0e4 with SMTP id e1csp19037lqp; Sat, 8 Jun 2024 04:39:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU75aD6CfBWDRKlmQVc3yaK6QHxuvz45EtpGY8I1y9Yu9jsCDEFi7bWyUn6nCV7Zr7Ym8YoppHUqihanITdn6M6CUgPfR+jOoz2rHTEBA== X-Google-Smtp-Source: AGHT+IEveLf8prdL5hFN5UkyuwE4de+sxoROxNIQWYrPX+FHlKWpRxrx5Ri6Vx9EShdrj9woXaCh X-Received: by 2002:a05:6358:63a3:b0:186:2990:adb6 with SMTP id e5c5f4694b2df-19f1fceb8damr585716455d.2.1717846775593; Sat, 08 Jun 2024 04:39:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717846775; cv=pass; d=google.com; s=arc-20160816; b=iC/p11QXriSzafUsHeNV0yFst21ZUcd4LdukZ4qlJuPzbhFp2UuJD+LDW6nmQpwnwV eEZbKbVaKZFBHTKAF5TkeTlpInAZGeoh6STzSykqclRIe6NmhrTH3sIS2f97q7vuco+X 0FZXeTJcJLt3kaVo4ZdtY5m8pHLEg2CiwKrGBt4EP8bAk4Mro9BkTTUZhr3P95EjrFyJ 6uSBvrwvYugideNxq0f9W446LE7d41LRj/XBuuA2pZhf5GkAZCCyXdVmubBvJaaDcLBQ 5VqrDoKC/FOSw3puVl4+CdDPD5gcsC8Fz4UaltSSJqleSBoiaWMdqF98589xX4kRbCmZ Yl7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DVgpi40ZZnOp6SWPyn28IFba5oSmENk1Yb0zhicBhag=; fh=9pg4Xar+ulR0Ro8wXHgApnotBkyus97apcDbThLiMpY=; b=ZOtHN6qx2xad8RtLYtduw4FhI1vdXiwBKNv+758YjxJJbdFgIgnCLjVusivCDTIrGj LDWZRgc3sLCDvtSyoBfaHlaeNYuq5//PETRRe3yav9buT7bc6EcYdkM74IwQNSkrSQ0D lFeCaRdKl2QwgdZ/SC+IXdT8sucSRhRUW5p3EKP914E17Y61Fp3aCgM1i4tN6b40W4N+ q2lmVytF9XWSyKhh65qLeP9EYnuDqQnx2M9K/vwTjNOTWnXkaghCalyEYsGWjFse5uXo yT190CfbZXiVsf5r7jxH/wJCUwGOX+2GneNbNvOsST1IAP8qcZ2/ffU7+7UUit0yctRf npkA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nx4eyENp; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-207019-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207019-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6e9b8100965si195730a12.809.2024.06.08.04.39.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jun 2024 04:39:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207019-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nx4eyENp; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-207019-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207019-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 31DFF282A54 for ; Sat, 8 Jun 2024 11:39:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8CE5B178382; Sat, 8 Jun 2024 11:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nx4eyENp" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B24FD155758; Sat, 8 Jun 2024 11:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717846768; cv=none; b=Yz9NiS6JW/fGSDNdiD74Ke7dg/y/+liKinbJvuSL3exOfwvskV6xr36KNd10AVHFcZrAbxuUMrbSmHlerRM1fmAoc3KfU6fkVcNUnSkBjQivluZS+XPoyYDiviNFaTGVmSR5iy/8SCOyA1quW6CHxOcXeF2XhBAsqVWFcKgJHic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717846768; c=relaxed/simple; bh=hESuc5jTKHJYwPbjzd8756nTEyiEv2rREPyzDuxJeis=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ync4eSuASn7DbEPIvQgGXtrpM02B8b+NK0t9a5UWxCiM9yGSZelopBaDjM3m7GQDbfmg4U4GJVfFo4ogzXO6J0I3qjI1RGnVghPmrEYjxCJ0bLXMrCeKm9DLyh8B+2tywV6ovzqu5rjSxpKMqhG9VT9BHn9qwIN1tQ2PdRxtDfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nx4eyENp; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D59D0C2BD11; Sat, 8 Jun 2024 11:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717846768; bh=hESuc5jTKHJYwPbjzd8756nTEyiEv2rREPyzDuxJeis=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nx4eyENpPZRFrQlgSt9ifmD5RT9BN9IJoaO4Gw4o9PPgZbP7AwJdHoOFb8vSt/HvY wJYqC5l6JoRWuyEC1JBG/wxxSyfF4ksEi029T9BrIzcNIN0QGzeCRleDuvRia+c5jD drnXVbyLjXMK9N7Z11iDhDyDeGp4ZaYSwXOpR4Tg= Date: Sat, 8 Jun 2024 13:39:22 +0200 From: Greg KH To: "Ivan T. Ivanov" Cc: cve@kernel.org, linux-cve-announce@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: iio: adc: stm32-adc: harden against NULL pointer deref in stm32_adc_probe() Message-ID: <2024060807-quintet-pogo-3c8f@gregkh> References: <2024052159-CVE-2023-52802-81ce@gregkh> <20240605145123.78220-1-iivanov@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240605145123.78220-1-iivanov@suse.de> On Wed, Jun 05, 2024 at 05:51:23PM +0300, Ivan T. Ivanov wrote: > Hi, > > I could we drop this CVE? > > of_match_device() can not return NULL in this case. > > Even commit message agree on this: > > " ... In practice there is no known reasonable way to trigger this, but > in case one is added in future, harden the code by adding the check ..." Ugh, our fault, sorry about that, now rejected. Thanks again for the review! greg k-h