Received-SPF: pass (google.com: domain of linux-kernel+bounces-207029-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <4e0f5932-c7bc-4878-862c-1186cbecd71d@gmail.com>
In-Reply-To: <4e0f5932-c7bc-4878-862c-1186cbecd71d@gmail.com>
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date: Sat, 8 Jun 2024 14:16:05 +0200
Message-ID: <CANiq72kaVw_t=hCJ-qEr=9ybuOngAR6isnCK717dBEm7CFm2NQ@mail.gmail.com>
Subject: Re: [PATCH 1/1] arm: rust: Enable Rust support for ARMv7
To: Christian Schrefl <chrisi.schrefl@gmail.com>, Jamie Cunliffe <jamie.cunliffe@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>, 
	Sven Van Asbroeck <thesven73@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 8, 2024 at 12:30=E2=80=AFAM Christian Schrefl
<chrisi.schrefl@gmail.com> wrote:
>
> This is based on the code by Sven Van Asbroeck from the original
> rust branch and inspired by the AArch version by Jamie Cunliffe.

Thanks for mentioning that!

(AArch64 perhaps?)

> I have tested the rust samples and a custom simple MMIO module
> on on hardware (De1SoC FPGA + Arm A9 CPU).

Very nice to have tested it in real hardware, thanks!

(Duplicate "on on").

> +``arm``        Maintained        ARMv7 Little Endian only.

How hard would it be to test and maintain other versions, eventually?
I met Jamie recently, he may have some ideas here.

> -BINDGEN_TARGET_arm64   :=3D aarch64-linux-gnu
> +BINDGEN_TARGET_arm64:=3D aarch64-linux-gnu

Spurious change?

> +# Depending on how the architecute defines ARCH_SLAB_MINALIGN, bindgen m=
ight generate a binding.
> +# Disable this here as there is a const that will always be generated in=
 bindings_helper.c

Typo in "architecute". Also, I guess you mean `.h` instead. Please use
Markdown formatting for consistency with the rest of the file.

> +        panic!("arm uses the builtin rustc target");

Since ARM64 puts the name of the target in the message, it would be
nice to do the same (or perhaps it can be removed from the ARM64 one
otherwise).

Cheers,
Miguel