Received-SPF: pass (google.com: domain of linux-kernel+bounces-207057-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 8 Jun 2024 15:16:43 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Erick Archer <erick.archer@outlook.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, Kees Cook <keescook@chromium.org>,
 "Gustavo A. R. Silva" <gustavoars@kernel.org>, Justin Stitt
 <justinstitt@google.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] iio: event: use sizeof(*pointer) instead of
 sizeof(type)
Message-ID: <20240608151643.5f82e10d@jic23-huawei>
In-Reply-To: <AS8PR02MB7237D024459C314CECE72EAF8BFE2@AS8PR02MB7237.eurprd02.prod.outlook.com>
References: <AS8PR02MB7237D024459C314CECE72EAF8BFE2@AS8PR02MB7237.eurprd02.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun,  2 Jun 2024 19:23:54 +0200
Erick Archer <erick.archer@outlook.com> wrote:

> It is preferred to use sizeof(*pointer) instead of sizeof(type)
> due to the type of the variable can change and one needs not
> change the former (unlike the latter). At the same time refactor
> the NULL comparison.
> 
> This patch has no effect on runtime behavior.
> 
> Signed-off-by: Erick Archer <erick.archer@outlook.com>

Applied.
> ---
>  drivers/iio/industrialio-event.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index 910c1f14abd5..b99bfeff7d37 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -572,8 +572,8 @@ int iio_device_register_eventset(struct iio_dev *indio_dev)
>  	      iio_check_for_dynamic_events(indio_dev)))
>  		return 0;
>  
> -	ev_int = kzalloc(sizeof(struct iio_event_interface), GFP_KERNEL);
> -	if (ev_int == NULL)
> +	ev_int = kzalloc(sizeof(*ev_int), GFP_KERNEL);
> +	if (!ev_int)
>  		return -ENOMEM;
>  
>  	iio_dev_opaque->event_interface = ev_int;