Received: by 2002:ab2:68c1:0:b0:1fd:9a81:d0e4 with SMTP id e1csp117130lqp; Sat, 8 Jun 2024 08:22:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV3h4YTh5Eofac39qlwcJXnMGJ7lV2ZsVb3W6K1Gy6z5VlC/4A23dIggKXKVntiGCRFTL3u75oApEkKdcbBf5Lp1b/6N3gn6ql02tARUA== X-Google-Smtp-Source: AGHT+IGIVrvKEUj4JXILA2zwUEf7DI/Ue40GHzcVW7Ruz2W4wYQQheg+oRi1mSCcBPJujPoNzWZ+ X-Received: by 2002:a17:906:f595:b0:a62:b97b:b3bb with SMTP id a640c23a62f3a-a6cdbfec39dmr394319866b.74.1717860130444; Sat, 08 Jun 2024 08:22:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717860130; cv=pass; d=google.com; s=arc-20160816; b=R7zt3Bifh6jJHreemGRVy1j4/OC4l+VvytZQXJc1eiEut8dIedUiVfX7zzyxDQ+l/y 8sR2yohAsaMv4hpbg4tuiNqENOmUHUH3Ma13RsqPLJYWaZRZa/qN8ySIIxyxpYduMKya nHJpN+5ntL57gug8Z8PBIx0AMGbwRmYgw2mgQSJFdSnfbCDwzWUR5YudWwsyMZzeLqy+ LqNZ3wLYhLli58bYVqeHrSJ9ll+m6ncz8YEvCtq83l8TBcq23cVum9Rx4YH5jABqlcST Ke+LOQnLNOgdNdUL+JluslrddrmHgHK9WWPRdU3dUxZzLk2SaljBmGebEa2jWrm8tMKT 3qPQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fOfNTZ0fZaupGe7KxaVKr02w/o4v/y907pnEioDgJkw=; fh=KLumLzRbXG94RI43c7r3MbtxEchZ3nDC143PkELQbDQ=; b=SbkNnP1Nm2wY7p+rVA5V4Jb8htwzVYyM3ts662zCgLgFh8ydoaELEdP6Cw+wgdZLSq U+GNx1Ri61bOhoYtmGgAQQ3QIhKWUvIAc5K4io6JLlsYI/FWSnvtn/+/WhqSAoUFyMtN Fw4DLM8EcCw93+sSRhbRiT8udFSjYQ/lsqCU80n5G75bYqJZuBtjlccnnee1Uxt8KZz5 ffUxKlK2WjoTKZtFv9SFrlsISlJjzTN0ujD4ew7ZCCHFA9lheE5lWiDWngTjr5yDeY0Q vm2z8du3RC0lYQ07VdeEWwHUcrhDy4cKvbKSl4guHGQ6oGnredZ+2eNn+7z2vTtpSCTg mr3A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=VOUvEh4w; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-207094-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207094-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f0fcc108dsi27354266b.674.2024.06.08.08.22.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jun 2024 08:22:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207094-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=VOUvEh4w; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-207094-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207094-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2E8581F21BA4 for ; Sat, 8 Jun 2024 15:22:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B28DE17A91B; Sat, 8 Jun 2024 15:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VOUvEh4w" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D0431FBB; Sat, 8 Jun 2024 15:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717860118; cv=none; b=jnlWlWtaHGQfh0S0SjcKzNzoQTlx0Fnx9LujP0fT9yJdyuuxhBKY9t2YhwV5Ny18jSQZofkrFazUXU6qrI/pa8oW8khBGcJSvXtsUSKvaAw5cBKyvpuN9/dF6CoFen5Eg9KhCQ/f9Ehz8DMgjwdrxcR+iAyccvGQcbioT3rUVj0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717860118; c=relaxed/simple; bh=xKq0uZv7KiOKLRYrpZChOTMRtF6MphQYosnp2/2huOU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pQTa0ozrC49X6fAc3rHyHCX8QhBymMue1uIIUymgC2FexLdft4pbKUP6Ry+suItpVAUT2ptv3znFOvaH7R7v2+ZkJUombzcLsy/k0hHjq+2DXjx+K2qoxxDEjbjQWWkfFgRyvRYOrFTMsvI860PUTdzqvbApsf0jKYCe6OiWuRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=VOUvEh4w; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BF2AF471; Sat, 8 Jun 2024 17:21:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1717860105; bh=xKq0uZv7KiOKLRYrpZChOTMRtF6MphQYosnp2/2huOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VOUvEh4w+1llZFo92MhZtYmHtpH+Sogq83lkDskbmHy+EskQn7rYFYiGqYDVyrcnw IjyfCYZdM7dXxP1x0cCK7WisiTYPE6a70mmYP2S6752o8ospb771GTSZKWSQkrcy1M PSTrgv2jNUZcCVv/6D7JP6yXMhxm0vK0Hgc0tuh4= Date: Sat, 8 Jun 2024 18:21:36 +0300 From: Laurent Pinchart To: Rob Herring Cc: Marco Felsch , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: snps,dwmac: add phy-supply support Message-ID: <20240608152136.GA14446@pendragon.ideasonboard.com> References: <20230721110345.3925719-1-m.felsch@pengutronix.de> <20230721142433.GA1012219-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230721142433.GA1012219-robh@kernel.org> Hi Rob, On Fri, Jul 21, 2023 at 08:24:33AM -0600, Rob Herring wrote: > On Fri, Jul 21, 2023 at 01:03:43PM +0200, Marco Felsch wrote: > > Document the common phy-supply property to be able to specify a phy > > regulator. > > What common property? I don't see any such property in > ethernet-controller.yaml. > > > Signed-off-by: Marco Felsch > > Acked-by: Krzysztof Kozlowski > > --- > > Changelog: > > v4: > > - no changes > > v3: > > - no changes > > v2 > > - add ack-by > > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index ddf9522a5dc23..847ecb82b37ee 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -160,6 +160,9 @@ properties: > > can be passive (no SW requirement), and requires that the MAC operate > > in a different mode than the PHY in order to function. > > > > + phy-supply: > > + description: PHY regulator > > Is this for an serdes, sgmii, etc. type phy or ethernet phy? Either way, > this property belongs in the PHY's node because it is the PHY that has > supply connection. I'm guessing you put this here for the latter case > because ethernet PHYs on MDIO are "discoverable" except for the small > problem that powering them on is not discoverable. Any idea on how to solve that problem generically ? -- Regards, Laurent Pinchart