Received: by 2002:ab2:68c1:0:b0:1fd:9a81:d0e4 with SMTP id e1csp133368lqp; Sat, 8 Jun 2024 09:04:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUUz1WtBk+zhjEtJLyQsSE6zOozqlR6/rIk3nfivCNGb3roPoWawyM2vJbZ4ix3PPb4r6+BpIgqI3xmk7vB3kLJ6bv7mx0myUFWCbQj7Q== X-Google-Smtp-Source: AGHT+IFrYtgGNM0HpjTEwPm4MzmTsuzA+WbjeIhRpGH1p6jSgHURXaRHH1WWe668bV+13qLTFA/v X-Received: by 2002:a17:902:c40b:b0:1f4:b7ff:ac41 with SMTP id d9443c01a7336-1f6d0305cc3mr55125535ad.36.1717862649120; Sat, 08 Jun 2024 09:04:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717862649; cv=pass; d=google.com; s=arc-20160816; b=plYtWIRTJlfjYgaSWKuMA7LKHpAe/tMj7h2ABIYLixpho20dRIuh05W/PRhXkJsSE4 awmpLCP7wT2elItrReRN+6Hh0bHtqds46ZhfLhqlPtZJN0X+jPAz5eBbK5yzWQA85Pei GfgFQshFtG9eejBo2I+kRegdV1zV/e8nl6w1tcs1goiydJhDZqKMMKQUu9tMFLARXrz6 KYrZ9b8jvuY3sBC/F6jARUKYTL7oEdshPli76eznO6RV8yYfXyBl61iD7aW1yadeJqHc EiDZAmNNeoxz1FWPlWkSjLSd4oN8/7oQYX4k0i5Ehx1slKRFGvtvaeiWe6Ox3Bd828Xr Vmqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=qVkfmd0A4LSH9aeoF9S7AqEXOafs58bJBwLWsHiogQU=; fh=d+YGCukpMCCFlNzTdjYprwdyVKpHv5MO+iBHAm5xA4M=; b=FB5pVgsTS6zI0spWjCJV48Gy/QZ2BeeKsAR/CGmmYRd7kRUgLhDSTqRPLVYsyYx7h/ ApHqkS2BXx1U8QmGwMEcxat8c6ylrqw9f8C/zeWTrNeJ49+gM1mIkzQwE08m0YXI+2b0 mdw4jNW1v4F0XglDPFa/Ff1gTkNyCrFK+rH66RoSf/k7B6/73GgXMuX98ujOtUYn7Gx4 4xjDjEodwTroq9mCISh2QRhLtazxAKbxNC9O80v7cxNswXw7T+ZpfXGz3W+sF5mJ38jq P4qRx5bv+XgpW+HTsJAJ2Q4lASgRWErDE8KLpQxZ1OBPaldjASocQMic+E4CS7bmgRed Y40Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Yp9Beqws; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-207125-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207125-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f6bd7606desi19773605ad.93.2024.06.08.09.04.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jun 2024 09:04:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207125-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Yp9Beqws; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-207125-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207125-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B6E62281F29 for ; Sat, 8 Jun 2024 16:04:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C648217B406; Sat, 8 Jun 2024 16:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yp9Beqws" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 538C01E888 for ; Sat, 8 Jun 2024 16:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717862642; cv=none; b=qUQmFCskR3SSaIkhKNF9GTJbwHb61RHGMVzpZ9oS8p0Xe84cym8sNtvAZwfuzc/XGwJBaeTKmjOsgZkLtaPKo2EPX+lDtmLF/xfXW3Tw+rV21oa0cEIZiG8iAvwD9JmSU22KoKXR5BNQidqvYV0Zv6deEYkThMU1r/UPXVzBII0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717862642; c=relaxed/simple; bh=Cuz5O7o7P/GDYoHaIJ5Jm7qqJSDX3hdIyPx3hjVkLkQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NrYSGILgHISglJw5palW2SnluvgTOvOAdNZ2BBA+LzXViNoXJic7Nrj2YNyvs28aFmSpmrpmOWQfe0wlTHgIQd7sNFz5Ur9aJdfVOC3ZgzxX6QLp8oIv/EVtX+HXqxK1AhPipHIu9o4UUTsh1MheYQn5GVn7ZY7GtlRVpflo8vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yp9Beqws; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717862640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qVkfmd0A4LSH9aeoF9S7AqEXOafs58bJBwLWsHiogQU=; b=Yp9BeqwsuXxKC42RbLDAKniC5A+KrTOXFiwb3T6bQ7goskda6O9e6mEqlszofqSxKrwQeo 4Izp99G3Piyp7OdwftT+D9yS4QQCoBIUzIUI1h+Dc8bWW7L6uRnqmAepBVxCvu4qGOkWh2 WvKECf2B7QEuEZff9CMuYq+CeIN6R98= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-xgb4-x1XPom84P7GNcH5mQ-1; Sat, 08 Jun 2024 12:03:58 -0400 X-MC-Unique: xgb4-x1XPom84P7GNcH5mQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-35dbf83bb20so1947485f8f.2 for ; Sat, 08 Jun 2024 09:03:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717862637; x=1718467437; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qVkfmd0A4LSH9aeoF9S7AqEXOafs58bJBwLWsHiogQU=; b=wmugFn6g+6x3XWqSDcG5NFXrwWyi09fzd7YRuZm1tYntWNLZji3fUjz+mHSBJa+TlG 4naY/A+VoeoswhG+2D5jokXxvdnLCIX5P7I17uYi5zeMQZRHF8nTsVg/gFIw6OrwBb9j nCrGEE59Es4taZrV+5ahwT1tdGF41GZe+TjroRkvQ8PHZ8zxvHsm8OTSR7nOTt8C55fk HnU2EYd1UdM+ka2hgir1Y1fXGajFgAIZ1UufF3mDIwQtxuPgJ3qGE5d6RYGQYoO0PN0v NEU2MAlamqSIR7id5TlegzRRtEwvOBxXzxfCfifsb7lMeQn0uDAk5rDzloZsknIcl8/O cn/Q== X-Forwarded-Encrypted: i=1; AJvYcCUE5YNiSEtyhSk5yYAZsj4Yf4x01Dr9ldhG/5dOTlESWGJNcpmPsMjYka0LNhhvPzXORzKVNH2duMU3KcD7apQXFBC35QDMIgrpinlT X-Gm-Message-State: AOJu0Yz5KWWQ9SmEi3L6RR5cpPQZSqF3kCL6Agon/LFaG526mDnuPf7F 4Ua9yvEFox5cigBbp6haAgIYF3iSgwyJHjzP33lAHaBRLS43mwJI1zVjxAOd7r5/qjlYO/BNozD IQ9oKRFqpVHV37M0IZGYoZXiijCrzZGyhWT32WdxQ85g1rNvB+7U41ggsQYCNKg== X-Received: by 2002:a5d:648c:0:b0:35e:5b3c:b11f with SMTP id ffacd0b85a97d-35efedf69a6mr4136846f8f.58.1717862637317; Sat, 08 Jun 2024 09:03:57 -0700 (PDT) X-Received: by 2002:a5d:648c:0:b0:35e:5b3c:b11f with SMTP id ffacd0b85a97d-35efedf69a6mr4136835f8f.58.1717862636892; Sat, 08 Jun 2024 09:03:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c725:2c00:2436:de9:dfc8:5e67? (p200300cbc7252c0024360de9dfc85e67.dip0.t-ipconnect.de. [2003:cb:c725:2c00:2436:de9:dfc8:5e67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f0f996ee3sm2535873f8f.71.2024.06.08.09.03.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Jun 2024 09:03:56 -0700 (PDT) Message-ID: <617f9e36-9334-4630-a6b9-473f2dd570d4@redhat.com> Date: Sat, 8 Jun 2024 18:03:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/gup: don't check page lru flag before draining it To: Matthew Wilcox , yangge1116 Cc: Baolin Wang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuzixing@hygon.cn References: <0d7a4405-9a2e-4bd1-ba89-a31486155233@redhat.com> <776de760-e817-43b2-bd00-8ce96f4e37a8@redhat.com> <7063920f-963a-4b3e-a3f3-c5cc227bc877@redhat.com> <48150a28-ed48-49ff-9432-9cd30cda4da4@linux.alibaba.com> <11ef3deb-d1e3-46d5-97ed-9ba3c1fbbba9@redhat.com> <697a9bc2-a655-4035-aa5e-7d3acb23e79d@redhat.com> <3a368e38-a4cb-413e-a6d9-41c6b3dbd5ae@redhat.com> <48fb0e58-16d1-7956-cf35-74741826617a@126.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08.06.24 17:15, Matthew Wilcox wrote: > On Sat, Jun 08, 2024 at 12:38:49PM +0800, yangge1116 wrote: >> Can we add a PG_lru_batch flag to determine whether a page is in lru batch? >> If we can, seems this problem will be easier. > > Page flags are in short supply. You'd need a really good justification. > A flag would not be able to handle the "part of multiple LRU batches" that should currently possible (when to clear the flag?). Well, if we have to keep supporting that. If we only to be part in a single LRU batch, a new flag could work and we could still allow isolating a folio from LRU while in some LRU batch. If we could handle it using the existing flags, that would of course be better (wondering if we could store more information in the existing flags by using a different encoding for the different states). The temporary clearing of the LRU flag we do right now tells me that it's already not 100% reliable, so the question is how much more unreliable we can make it before it would hurt :) -- Cheers, David / dhildenb