Received-SPF: pass (google.com: domain of linux-kernel+bounces-207158-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 8 Jun 2024 18:22:40 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>, Lucas Stankus
 <lucas.p.stankus@gmail.com>, Lars-Peter Clausen <lars@metafoo.de>, Michael
 Hennerich <Michael.Hennerich@analog.com>, Puranjay Mohan
 <puranjay@kernel.org>, Ramona Bolboaca <ramona.bolboaca@analog.com>,
 Oleksij Rempel <o.rempel@pengutronix.de>, kernel@pengutronix.de, Cosmin
 Tanislav <cosmin.tanislav@analog.com>, Marius Cristea
 <marius.cristea@microchip.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] iio: accel: adxl313: simplify with
 spi_get_device_match_data()
Message-ID: <20240608182240.1e3a8153@jic23-huawei>
In-Reply-To: <69e1a5b1-e5ce-4bcc-a0c4-2d02e777c296@linaro.org>
References: <20240606-spi-match-data-v1-0-320b291ee1fe@linaro.org>
	<20240606-spi-match-data-v1-1-320b291ee1fe@linaro.org>
	<7ecabb8e342b9bd4fc2552bce29dc8c7a98971ee.camel@gmail.com>
	<69e1a5b1-e5ce-4bcc-a0c4-2d02e777c296@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 7 Jun 2024 11:18:54 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 07/06/2024 10:57, Nuno S=C3=A1 wrote:
> > On Thu, 2024-06-06 at 16:26 +0200, Krzysztof Kozlowski wrote: =20
> >> Use spi_get_device_match_data() helper to simplify a bit the driver.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> =C2=A0drivers/iio/accel/adxl313_spi.c | 8 +-------
> >> =C2=A01 file changed, 1 insertion(+), 7 deletions(-)
> >>
> >> diff --git a/drivers/iio/accel/adxl313_spi.c b/drivers/iio/accel/adxl3=
13_spi.c
> >> index b7cc15678a2b..6f8d73f6e5a9 100644
> >> --- a/drivers/iio/accel/adxl313_spi.c
> >> +++ b/drivers/iio/accel/adxl313_spi.c
> >> @@ -72,13 +72,7 @@ static int adxl313_spi_probe(struct spi_device *spi)
> >> =C2=A0	if (ret)
> >> =C2=A0		return ret;
> >> =C2=A0
> >> -	/*
> >> -	 * Retrieves device specific data as a pointer to a
> >> -	 * adxl313_chip_info structure
> >> -	 */
> >> -	chip_data =3D device_get_match_data(&spi->dev);
> >> -	if (!chip_data)
> >> -		chip_data =3D (const struct adxl313_chip_info
> >> *)spi_get_device_id(spi)->driver_data;
> >> +	chip_data =3D spi_get_device_match_data(spi);
> >> =C2=A0 =20
> >=20
> > I understand you're sticking with the original code but since you're do=
ing this,
> > could we maybe add proper error checking for the call? Maybe Jonathan c=
an even
> > tweak that while applying...
> >=20
> > (same comment for patch 3) =20
>=20
> I consider that a separate patch/work, because it would have functional
> impact.

Agreed. Though error checking on these is normally paranoia / readability t=
hing
as we probed from some firmware match and all those entries are present, so
it should just work.


>=20
> Best regards,
> Krzysztof
>=20