Received-SPF: pass (google.com: domain of linux-kernel+bounces-207164-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 8 Jun 2024 18:44:04 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>, lars@metafoo.de,
 robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
 matthias.bgg@gmail.com, lee@kernel.org, andy@kernel.org,
 nuno.sa@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com,
 marius.cristea@microchip.com, marcelo.schmitt@analog.com,
 fr0st61te@gmail.com, mitrutzceclan@gmail.com, mike.looijmans@topic.nl,
 marcus.folkesson@gmail.com, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,
 kernel@collabora.com
Subject: Re: [PATCH v2 4/5] iio: adc: Add support for MediaTek MT6357/8/9
 Auxiliary ADC
Message-ID: <20240608184404.5c34668f@jic23-huawei>
In-Reply-To: <575186dc-8a4a-4d93-98f0-d2271b0aa1fb@collabora.com>
References: <20240604123008.327424-1-angelogioacchino.delregno@collabora.com>
	<20240604123008.327424-5-angelogioacchino.delregno@collabora.com>
	<CAHp75Ve8qPLu+gS8o5Q5A20j_+AP_UVkOzdKqcnhUawA_sW+VA@mail.gmail.com>
	<575186dc-8a4a-4d93-98f0-d2271b0aa1fb@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 4 Jun 2024 15:24:31 +0200
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote:

> Il 04/06/24 15:22, Andy Shevchenko ha scritto:
> > On Tue, Jun 4, 2024 at 3:30=E2=80=AFPM AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@collabora.com> wrote: =20
> >>
> >> Add a driver to support reading the Auxiliary ADC IP found in the
> >> MediaTek MT6357, MT6358 and MT6359 Power Management ICs, featuring
> >> a different register layout, configurationm reset and ADC reading =20
> >=20
> > configuration
> >  =20
>=20
> Oh, oops! If there's no further comment to address, can this be fixed whi=
le
> applying, please?
>=20
Yes if Rob is happy with your response to his question on the
dt-binding.

LGTM as well btw.

Jonathan

> Otherwise I can send a v3 :-)
>=20
> >> sequence from the other already supported MediaTek SoC or PMIC
> >> (aux)ADC HW.
> >>
> >> This driver provides multiple ADC channels for system monitoring,
> >> such as battery voltage, PMIC temperature, PMIC-internal voltage
> >> regulators temperature, and others. =20
> >=20
> > Seems all my concerns were addressed, so
> > Reviewed-by: Andy Shevchenko <andy@kernel.org>
> >  =20
>=20
> Thanks!
> Angelo