Received-SPF: pass (google.com: domain of linux-kernel+bounces-207166-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 8 Jun 2024 18:51:21 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>, Lars-Peter Clausen
 <lars@metafoo.de>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Kevin Hilman
 <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin
 Blumenstingl <martin.blumenstingl@googlemail.com>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: amlogic,meson-saradc: add
 optional power-domains
Message-ID: <20240608185121.31a40d62@jic23-huawei>
In-Reply-To: <20240606-clothing-deceit-910ad6aebe1e@spud>
References: <20240605-topic-amlogic-upstream-bindings-fixes-power-domains-sardac-v1-1-40a8de6baa59@linaro.org>
	<20240605-abdomen-starch-4fd4d7ead431@spud>
	<1a82eeb8-bb95-4fad-acce-798ba0cda170@linaro.org>
	<20240606-clothing-deceit-910ad6aebe1e@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 6 Jun 2024 17:21:17 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Thu, Jun 06, 2024 at 09:54:22AM +0200, Neil Armstrong wrote:
> > On 05/06/2024 18:58, Conor Dooley wrote:  
> > > On Wed, Jun 05, 2024 at 11:37:08AM +0200, Neil Armstrong wrote:  
> > > > On newer SoCs, the SAR ADC hardware can require a power-domain to operate,
> > > > add it as optional.  
> > > 
> > > What about the older socs that don't have power domains, the property is
> > > now usable there?  
> > 
> > Old SoCs doesn't necessarily have an associated power domain, or was handled
> > by firmware, does it harm if we make it optional for older ones as well ?  
> 
> I mean, really all of these devices have a power domain, even if the DT
> doesn't describe one as it's hardly gonna work without power, so the
> commit message just seems odd to me. I don't care enough to ask for a
> new commit message though.
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Applied