Received-SPF: pass (google.com: domain of linux-kernel+bounces-207168-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 8 Jun 2024 19:06:00 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno Sa <nuno.sa@analog.com>
Cc: Petr Mladek <pmladek@suse.com>, Lars-Peter Clausen <lars@metafoo.de>,
 Olivier Moysan <olivier.moysan@foss.st.com>, Jyoti Bhayana
 <jbhayana@google.com>, "Andy Shevchenko"
 <andriy.shevchenko@linux.intel.com>, Chris Down <chris@chrisdown.name>,
 John Ogness <john.ogness@linutronix.de>, "Greg Kroah-Hartman"
 <gregkh@linuxfoundation.org>, Andi Shyti <andi.shyti@kernel.org>,
 <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] iio: temperature: ltc2983: convert to
 dev_err_probe()
Message-ID: <20240608190600.622dfd7f@jic23-huawei>
In-Reply-To: <20240606-dev-add_dev_errp_probe-v3-2-51bb229edd79@analog.com>
References: <20240606-dev-add_dev_errp_probe-v3-0-51bb229edd79@analog.com>
	<20240606-dev-add_dev_errp_probe-v3-2-51bb229edd79@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 6 Jun 2024 09:22:38 +0200
Nuno Sa <nuno.sa@analog.com> wrote:

> Use dev_err_probe() (and variants) in the probe() path. While at it, made
> some simple improvements:
>  * Explicitly included the err.h and errno.h headers;
>  * Removed some unnecessary line breaks;
>  * Removed a redundant 'else';
>  * Added some missing \n to prink.
> 
> Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> ---


> @@ -1296,8 +1268,8 @@ static int ltc2983_reg_access(struct iio_dev *indio_dev,
>  
>  	if (readval)
>  		return regmap_read(st->regmap, reg, readval);
> -	else
> -		return regmap_write(st->regmap, reg, writeval);
> +
> +	return regmap_write(st->regmap, reg, writeval);
>  }

Unrelated.

Otherwise updates look correct to me.