Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762725AbYBFME3 (ORCPT ); Wed, 6 Feb 2008 07:04:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761899AbYBFMES (ORCPT ); Wed, 6 Feb 2008 07:04:18 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:40543 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761876AbYBFMER (ORCPT ); Wed, 6 Feb 2008 07:04:17 -0500 Message-ID: <47A9A23E.5060006@garzik.org> Date: Wed, 06 Feb 2008 07:04:14 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Robert Hancock CC: linux-kernel , ide , Tejun Heo Subject: Re: [PATCH] sata_nv: fix ATAPI issues with memory over 4GB (v7) References: <47A7BE36.1010902@shaw.ca> In-Reply-To: <47A7BE36.1010902@shaw.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 22 Robert Hancock wrote: > This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode > on systems with memory located above 4GB. We need to delay setting the 64-bit > DMA mask until the PRD table and padding buffer are allocated so that they don't > get allocated above 4GB and break legacy mode (which is needed for ATAPI > devices). Also, if either port is in ATAPI mode we need to set the DMA mask > for the PCI device to 32-bit to ensure that the IOMMU code properly bounces > requests above 4GB, as it appears setting the bounce limit does not guarantee > that we will not try to map requests above this point. > > Reported to fix https://bugzilla.redhat.com/show_bug.cgi?id=351451 > > Signed-off-by: Robert Hancock applied, though it can still be improved... let's see if this sticks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/