Received-SPF: pass (google.com: domain of linux-kernel+bounces-207175-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: i2f914587:Fastmail
Message-ID: <279b22e7-56ab-49ce-8b35-3a68258a4a91@the-space.agency>
Date: Sat, 8 Jun 2024 21:01:23 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add FriendlyElec CM3588 NAS
 board
To: Sebastian Kropatsch <seb-dev@mail.de>, Heiko Stuebner <heiko@sntech.de>,
 linux-rockchip@lists.infradead.org,
 Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
 Dragan Simic <dsimic@manjaro.org>, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240602211901.237769-1-seb-dev@mail.de>
 <20240602202132.2012-2-seb-dev@mail.de>
 <c4087311-cbd2-415e-a582-3565f2f62e81@the-space.agency>
 <11747652.CDJkKcVGEf@phil> <f5cfcf3e-27e5-464a-9adf-261753ad6de7@mail.de>
Content-Language: en-US
From: me@the-space.agency
In-Reply-To: <f5cfcf3e-27e5-464a-9adf-261753ad6de7@mail.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hey Sebastian,

On 08.06.2024 19:22, Sebastian Kropatsch wrote:
> But matching the schematics won't be possible either way, since
> e.g. there is only one single 5v regulator acc. to the schematic
> (vcc_5v0_sys), but vcc_5v0_host_20, vcc_5v0_host_30, vbus_5v0_typec
> and so on are needed since each device has a different control pin
> to enable its power. Or is there a better way to solve this while
> having only one 5v regulator node but still being able to set the
> control pins separately for the different USB ports?
> 
> Cheers,
> Sebastian
> 
> [1] 
> https://wiki.friendlyelec.com/wiki/images/1/15/CM3588_NAS_SDK_2309_SCH.PDF


There are these SY6280AAC power switches, which have enable pins and 
unique power net names coming out of them. I think it would be best to 
treat those as regulators. i.e.:
- Page 4 C4 has GPIO1_D2 as enable, outputting VBUS5V0_TYPEC
- Page 17 D4 has GPIO4_B0 as enable, outputting USB3_PORT1_5V
- Page 17 C4 has GPIO3_A5 as enable, outputting USB3_PORT2_5V
- Page 17 B4 has GPIO1_A4 as enable, outputting USB2_PORT_5V

Each can just be seen as a regulator outputting either 0V or 5V.

Kind regards,
Space