Received-SPF: pass (google.com: domain of linux-kernel+bounces-207186-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 8 Jun 2024 20:49:06 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm cache metadata: remove unused struct 'thunk'
Message-ID: <ZmTDwlUVu6HAyJ_X@gallifrey>
References: <20240523210550.309116-1-linux@treblig.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20240523210550.309116-1-linux@treblig.org>
User-Agent: Mutt/2.2.12 (2023-09-09)

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'thunk' has been unused since
> commit f177940a8091 ("dm cache metadata: switch to using the new
> cursor api for loading metadata").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping

> ---
>  drivers/md/dm-cache-metadata.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
> index 96751cd3d181..0ad9dc1824fa 100644
> --- a/drivers/md/dm-cache-metadata.c
> +++ b/drivers/md/dm-cache-metadata.c
> @@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
>  	return r;
>  }
>  
> -struct thunk {
> -	load_mapping_fn fn;
> -	void *context;
> -
> -	struct dm_cache_metadata *cmd;
> -	bool respect_dirty_flags;
> -	bool hints_valid;
> -};
> -
>  static bool policy_unchanged(struct dm_cache_metadata *cmd,
>  			     struct dm_cache_policy *policy)
>  {
> -- 
> 2.45.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/