Received-SPF: pass (google.com: domain of linux-kernel+bounces-207204-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: i6a694271:Fastmail
Date: Sat, 8 Jun 2024 15:23:07 -0600
From: Daniel Xu <dxu@dxuuu.xyz>
To: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, 
	bpf@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-trace-kernel@vger.kernel.org, fsverity@lists.linux.dev, andrii@kernel.org, olsajiri@gmail.com, 
	quentin@isovalent.com, alan.maguire@oracle.com, acme@kernel.org, eddyz87@gmail.com
Cc: kernel-team@meta.com
Subject: Re: [PATCH bpf-next v4 00/12] bpf: Support dumping kfunc prototypes
 from BTF
Message-ID: <u42jmbratxsej74zrtzn47j7evmdksswyrp6kfvr5tze36qcwt@mbl5e7fkekrz>
References: <cover.1717881178.git.dxu@dxuuu.xyz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1717881178.git.dxu@dxuuu.xyz>

On Sat, Jun 08, 2024 at 03:15:56PM GMT, Daniel Xu wrote:
> This patchset enables both detecting as well as dumping compilable
> prototypes for kfuncs.
> 
> The first commit instructs pahole to DECL_TAG kfuncs when available.
> This requires v1.27 or newer. v1.27 is nearing release at time of
> writing. Following this, users will be able to look at BTF inside
> vmlinux (or modules) and check if the kfunc they want is available.
> 
> The final commit teaches bpftool how to dump kfunc prototypes. This
> is done for developer convenience.
> 
> The rest of the commits are fixups to enable selftests to use the
> newly dumped kfunc prototypes. With these, selftests will regularly
> exercise the newly added codepaths.

I tested that this patchset works for both pahole:

    <1.27: https://github.com/kernel-patches/bpf/pull/7168
    >=1.27: https://github.com/kernel-patches/bpf/pull/7163

I meant to include that in the cover letter but I forgot. I'll try to
remember next time.