Received-SPF: pass (google.com: domain of linux-kernel+bounces-207324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 9 Jun 2024 13:46:18 +0300
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, weh@microsoft.com, sharmaajay@microsoft.com,
	longli@microsoft.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next v2 1/1] RDMA/mana_ib: process QP error events
 in mana_ib
Message-ID: <20240609104618.GC8976@unreal>
References: <1717754897-19858-1-git-send-email-kotaranov@linux.microsoft.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1717754897-19858-1-git-send-email-kotaranov@linux.microsoft.com>

On Fri, Jun 07, 2024 at 03:08:17AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> Process QP fatal events from the error event queue.
> For that, find the QP, using QPN from the event, and then call its
> event_handler. To find the QPs, store created RC QPs in an xarray.
> 
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> Reviewed-by: Wei Hu <weh@microsoft.com>
> ---
> 
> v2 is the same code, but some code is moved into helper functions
> 
> v1->v2
> * Introduced helpers to add and remove QPs to/from the table
> * Introduced helpers to get and put QP references
> 
>  drivers/infiniband/hw/mana/device.c           |  3 ++
>  drivers/infiniband/hw/mana/main.c             | 31 +++++++++++++++++--
>  drivers/infiniband/hw/mana/mana_ib.h          | 23 ++++++++++++++
>  drivers/infiniband/hw/mana/qp.c               | 20 ++++++++++++
>  .../net/ethernet/microsoft/mana/gdma_main.c   |  1 +
>  include/net/mana/gdma.h                       |  1 +
>  6 files changed, 77 insertions(+), 2 deletions(-)

Please run checkpatch.pl on your patches before sending them. I fixed it
and applied.

➜  kernel git:(wip/leon-for-next) mkt ci
878a8e752041 (HEAD -> build) RDMA/mana_ib: process QP error events in mana_ib
WARNING: line length of 88 exceeds 80 columns
#133: FILE: drivers/infiniband/hw/mana/mana_ib.h:340:
+static inline struct mana_ib_qp *mana_get_qp_ref(struct mana_ib_dev *mdev, uint32_t qid)

WARNING: line length of 82 exceeds 80 columns
#167: FILE: drivers/infiniband/hw/mana/qp.c:405:
+       return xa_insert_irq(&mdev->qp_table_wq, qp->ibqp.qp_num, qp, GFP_KERNEL);

WARNING: line length of 81 exceeds 80 columns
#170: FILE: drivers/infiniband/hw/mana/qp.c:408:
+static void mana_table_remove_qp(struct mana_ib_dev *mdev, struct mana_ib_qp *qp)

Thanks