Received-SPF: pass (google.com: domain of linux-kernel+bounces-207358-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 09 Jun 2024 13:32:38 +0100
Message-ID: <864ja2l2jd.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Jianjun Wang <jianjun.wang@mediatek.com>,	Lorenzo Pieralisi
 <lpieralisi@kernel.org>,	Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?=
 <kw@linux.com>,	Rob Herring <robh@kernel.org>,	Bjorn Helgaas
 <bhelgaas@google.com>,	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,	Ryder
 Lee <ryder.lee@mediatek.com>,	linux-pci@vger.kernel.org,
	linux-mediatek@lists.infradead.org,	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,	jieyy.yang@mediatek.com,
	chuanjia.liu@mediatek.com,	qizhong.cheng@mediatek.com,
	jian.yang@mediatek.com,	jianguo.zhang@mediatek.com
Subject: Re: [PATCH v2 1/3] PCI: mediatek: Allocate MSI address with dmam_alloc_coherent()
In-Reply-To: <20240608090152.GB3282@thinkpad>
References: <20231211085256.31292-1-jianjun.wang@mediatek.com>
	<20231211085256.31292-2-jianjun.wang@mediatek.com>
	<20240608090152.GB3282@thinkpad>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Sat, 08 Jun 2024 10:01:52 +0100,
Manivannan Sadhasivam <mani@kernel.org> wrote:
> 
> On Mon, Dec 11, 2023 at 04:52:54PM +0800, Jianjun Wang wrote:
> > Use dmam_alloc_coherent() to allocate the MSI address, instead of using
> > virt_to_phys().
> > 
> 
> What is the reason for this change? So now PCIE_MSI_VECTOR becomes unused?

More importantly, this is yet another example of the DW reference
driver nonsense, where memory is allocated for *MSI*, while the whole
point of MSIs is that it is a write that doesn't target memory, making
any form of RAM allocation absolutely pointless.

This silly approach has been cargo-culted for years, and while I
caught a few in my time, you can't beat copy-paste.

IMO, this patch is only making things worse instead of fixing things.

	M.

-- 
Without deviation from the norm, progress is not possible.