Received: by 2002:ab2:68c1:0:b0:1fd:9a81:d0e4 with SMTP id e1csp525872lqp; Sun, 9 Jun 2024 07:08:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUEk/y8gqTTQ3RrzEhaL9epr2qtdRFGLFej+omRXcxrnQzFUnnnZS+JolIfWRTQ5gWf/CwU7zcXEtcik2Q9BHZu0P4/TiLpQO3pat9WTw== X-Google-Smtp-Source: AGHT+IG7YJphCB+lE+sfK7sxVLO1d813ZmiHhXLE3RDJfvQPzFRy61IOpJYqk80Zf5wZs3lLqlV/ X-Received: by 2002:a05:6a20:258e:b0:1b5:510a:ce3f with SMTP id adf61e73a8af0-1b5510acf71mr3552201637.36.1717942094013; Sun, 09 Jun 2024 07:08:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717942094; cv=pass; d=google.com; s=arc-20160816; b=Yuu/Y/RJTsv7xpxBfYVLjzqGBUwU6X6AferxaW/yJja9CLfm9r0RzHAwS8XUCO4zSC paMTB/Bq/Tk3i2O1byrLgW9VXqYuvA3NhH+tod+cu6/bmLC0Hw4qyPalSY61HDdEUEIH S4iQDHuXQbJUkjJmqTfmExBjLI10Q4POZ52OnlPMpoV1aJh1i5AnrN51+P003is4lfb0 Kl5FikSbS8r1RG/Uz+wHf3A/kl8K2OR/UC1UDUGFfYOvu2KfjVelPeZB2ipFslTgWsTu XyeiCVx11TZbn0o9G36sNXmmNLnJKr87Vj7OgXI7GYinVQP7mNoon6VNG7VmnfpIprBN 67tA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=ZYc6ViqrmU+5mJe+gq/gz48E0wJG1FsE0M6nt2ykiS0=; fh=qFQ72YRWc7DFaQ1LWA54Gx1cpLgLMjAjnQ9ekypwP+Q=; b=WzXYLb/mm/2QeIouS21GIPyKNAe9Zan9Z9p+UcYONfntmqQjMsox/8QWVuYj6dT+qa v4MnhXc7l2Z38CzEzDeKYn82MM1eZ+JJCS96tbDkgZ8yzDuonAKosrbJ9mRlo5T+AdD3 kIThSMK8RHRIkKRNrZ+eO2xdFNdNJgd6K2rHFNzOorVF20zGC2Xkquy6zE/ayZ6R5Hjq pugbGYCADYh+buBtzZ9Ke9MEg3LMt960up6BrvIBWo4dol6Jr6MwsWv8Sj7uTZ4GLk+1 vJBQg0ehQLJz1Z2Z6QK12P9n6Nfq2fhWulPiqjLyh9gmOREvyuzc4hag8lEx6UFmDD5B 733Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=mLG6eW5Z; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-207378-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207378-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d2e1a72fcca58-70420192aafsi2538959b3a.126.2024.06.09.07.08.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jun 2024 07:08:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207378-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=mLG6eW5Z; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-207378-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207378-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9AC3D2815DE for ; Sun, 9 Jun 2024 14:08:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 43111446B4; Sun, 9 Jun 2024 14:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="mLG6eW5Z" Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72BC05258; Sun, 9 Jun 2024 14:08:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.72.192.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717942084; cv=none; b=ZhjXb/rWwVzXVwijYJE5anURTKUih2EXYHRuwmj7yoHf80HptOzGbuYZOSDGviZ45CtHPsi4SATLXTaUQKOVrnFMw5AmqREwnxH0uf8oe+tsQ96Zt15r0gvvEu4d8x/t6cNBfIWYIgnKyUtQo0LSDTeWtGUpM30j2p+azT9y+Nc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717942084; c=relaxed/simple; bh=OBxLFjmBv5Y1bDFc5KIIMYkCmQY5Bu976Hj/qpkXfiI=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=ora4sOVQ4FDeFMxPoEST2v4opEbiFCPSTKQcejDs9QuY3Elz2eP6s1qzfcdt/K6Qa/CgWIhFLx/kNlvuxi8JABoaIbEACv55eDArwyoq8VMIdAFAA9mvFp2vBW2I0O23W3KXRg3BbIm1TRKRp7sNMtRJDj9FZy7jQumXuiiPSyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=mLG6eW5Z; arc=none smtp.client-ip=217.72.192.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1717942041; x=1718546841; i=markus.elfring@web.de; bh=ZYc6ViqrmU+5mJe+gq/gz48E0wJG1FsE0M6nt2ykiS0=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=mLG6eW5ZLwDVlW933fYXZTqHYdugG/gYiuVtSYKNGN8i9K+1Jura0dlf5+58RAgW 8OxdpUcJoZHM2CUgAp48zsTGW0BD+8mTk4pE4diilOdDeAJgKtzcHjH1TL38kYfkH u3Y0D2zQiqCwVSWVaXgE2PZ72ijaahSXNWxG2Vhkvms5f19vKFYnfsaPNgeEZwIbI TQKfoaSoXv+ng1GZeyyH6TBxsV6ERM6G8bL7hdNalriUncVsVjlKFcnvmp6qdDi+4 vYrnMop5Eq0i2TkATHf1MZPUexhnSjNQVosWKX8qi8+Vege8+VsWRQUlqdv/Ck+xf yAHVNNfuzXW8YgSPww== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MaHWx-1rswnd3yJ3-00LQdr; Sun, 09 Jun 2024 16:07:21 +0200 Message-ID: <85e31039-15ee-416f-89fc-a018307bc7b6@web.de> Date: Sun, 9 Jun 2024 16:07:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Zhang Qiao , kernel-janitors@vger.kernel.org, Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Mel Gorman , Peter Zijlstra , Steven Rostedt , Valentin Schneider , Vincent Guittot Cc: LKML References: <20240606121133.2218723-1-zhangqiao22@huawei.com> Subject: Re: [PATCH] sched: Initialize the vruntime of a new task when it is first enqueued Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240606121133.2218723-1-zhangqiao22@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:gQloGkDdGamf40XcJqdP+/GPIiZ0zAPzjglU3CwQ7ifISUNyeWZ jTD2swiwY9ZRM9lWF7g6jlqHsNrtZ4CZ2EVB9QQIYNqWCNHw1DjFcQYs2DBy895JYonfsvP IPJIcX+irmEs+y3p9c8Ck0cLkrSgVOHRfS8x9aGW1OmUYncFAIGpS/VPBp/nBiQml2JIShg FFs/qjHCYEJo7kiGXeKNQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:jFA0np/W/f0=;famAjMx3WEWs2eRGOOmCmCvUQ41 6WY6ikmPfe5ruKAhQXoIxV9tzTBJY+k7qrt3n/relM0fThejpt4HBMvpiTFKmzyT88vcJPTvD hlHPK8AJhPK1e4GAgAxYNdavgwamkg36i7FfNs2RwAOhhKdMbDfQi+qaS78JOE5ElgOSRz9Xg k7XmPxGCh30Be/bI0cczg1twhpBoNNqlV3ZApxA8feWkWs28tffmHTncX5SpLoAJVnGw2IhMm /WNZIWH+psKMDcj6PCniBKrbekCmQM5DXH2AYe0MRcQa/tflXenBYxXERddGRmQCR6+1ltAFe me3Kt+Tzdcy7D1sY3qvuebhw4GN3IOvIC/aowt/9szWm1hDxfwa5PGLVyx3SZJwAnQpnfqjJv HZ+naZBkhyN5CLuK4mTcvfreLigeINWO6U5L0Rhf0/RVsn67Mzd2hY57MkQHwFq1apd6Xu9oP 9eFJiKW7ptJutBfzsjYGFfBNAvOJraJOTmLFs3cRah63NEzNFdPdi6rmGNrJ0ku4s96/Cg1Jz Or3HozKvktqxPYavtRySYvEdIsXZ2WvLYR61+1w/0ZgXMsIs2KOFfeyk1UQ3E03He0CbwIByi T6MtVK3IwwbjAYNEcwycfOwjYrqCJhI3rak4Sw5Sn9lER0n9Th7dMLs/blBqQSUEh6yB2nj/r hJRM91h91PLWfG2HiJYyoB+KG0PZOgGpAExmQxG/t5+MACQQQMJK9YJBopTDt3wy4ycYT0zyL xHuKRTiW73/rh5Yb7/am/8Vpn3qRGSmnSgFBa4fLTBL71tSAqt/emf5yaV96+3pGINgBv/W0M lp84TzczjwNj9114GalgDCwwztbw0y0EGR2LoII0T71Lk= > When create a new task, =E2=80=A6 creating? > Because it use current cpu =E2=80=A6 uses current CPU? > To optimize this case, we pass ENQUEUE_INITIAL flag to > activate_task() in wake_up_new_task(), in this way, > when place_entity is called in enqueue_entity(), the =E2=80=A6 Please improve such a change description also according to word wrapping because of a bit longer text line lengths. Regards, Markus