Received-SPF: pass (google.com: domain of linux-kernel+bounces-207441-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <0e439d73-aff5-4d56-9a3c-b29867132db1@web.de>
Date: Sun, 9 Jun 2024 19:20:49 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Olivier Dautricourt <olivierdautricourt@gmail.com>,
 dmaengine@vger.kernel.org, Stefan Roese <sr@denx.de>,
 Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Eric Schwarz <eas@sw-optimization.com>
References: <20240608213216.25087-2-olivierdautricourt@gmail.com>
Subject: Re: [PATCH v2 2/3] dmaengine: altera-msgdma: cleanup after completing
 all descriptors
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240608213216.25087-2-olivierdautricourt@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:XHO2VXyCijQ=;+c1+GZAFfFDrt40CmF4XbfgW8K7
 yFFK9uB+m7yA5H2E9sJvFhR9HSRjmw2HqXizcWHDL7PcNakVjlplu8cHSAax7jMiMVST6z+dA
 Q7xNB4ebOwFeIT5Z4Kh7eaEI69PFaTTO2rXnY1fREA0p/cQXR+T9gjv+GAJjXfbOEmur//eWa
 ndt3RFAV3Uh5F1jBtUqqlZZwKTqtxbgZiA6dXe9zmSQDV0DwzLGaQWYQW8SRj9egiXR1PFPBM
 yvjKg+HhedT0v2JObiGUxTXSb5VBdxprazcKVbcbWPdIPpnxaDH3dCjoT7NsD0MRdmgXLnmQO
 pmm3X0XNcThSTKl32ugGo1rlAjADqEmwHX/ZjEoYvD9lRFoja2HEkupJzRmerj7ZmPOaLVZ7J
 hTL6TJeDcL+OMjyoXP5jea1PlB/PWDHjIrLKAkKyx/opNab7jEa6BMKIDCeHzgE+tEFhY2R2G
 53/BXFPfiXDU4YiNmoRVmvqmgrkmuqJLeP7NyO3DFuF6low/blvEZPkFErDXjqGaSSZCbifgf
 38Fa9EtluFhIBj5fyFsYxP1RI0wLpBb8piP1ENB2qoZztKJPbzCizqaHukJF6dSnQF5Qd3Y9m
 N7IUmmpNTZaX9tIpOR5PGq0so98niVFj+FS4khquxNCh3QGnm/9LazzGDPnBwT0nS80skBYtN
 HCyltxF+NH9tRK7+n40eskXtXD4NFr9QLD9OxfjzNW03JLX0jh2J9TkNWHgApcuIgayMQbWTG
 Ir36Ws4vTQ5UNiwNwTvFtvvjcFkys6iL1QtTG94gB9ih2xg7Y1bWzFzOJSjhSDes4kGh3dv49
 xWGcV3xHXZm4rooISoTZW7Zie67F6bAUlZmxIMMBTy0Fk=

=E2=80=A6
> This fixes a Sparse warning because we first take the lock in
> msgdma_tasklet.
=E2=80=A6

Can the tag =E2=80=9CFixes=E2=80=9D become relevant for the proposed chang=
e?


=E2=80=A6
> +++ b/drivers/dma/altera-msgdma.c
> @@ -585,6 +585,8 @@ static void msgdma_chan_desc_cleanup(struct msgdma_d=
evice *mdev)
>  	struct msgdma_sw_desc *desc, *next;
>  	unsigned long irqflags;
>
> +	spin_lock_irqsave(&mdev->lock, irqflags);
> +
>  	list_for_each_entry_safe(desc, next, &mdev->done_list, node) {
>  		struct dmaengine_desc_callback cb;
>
> @@ -600,6 +602,8 @@ static void msgdma_chan_desc_cleanup(struct msgdma_d=
evice *mdev)
>  		/* Run any dependencies, then free the descriptor */
>  		msgdma_free_descriptor(mdev, desc);
>  	}
> +
> +	spin_unlock_irqrestore(&mdev->lock, irqflags);
>  }
=E2=80=A6

Would you become interested to apply the guard =E2=80=9Cspinlock_irqsave=
=E2=80=9D?
https://elixir.bootlin.com/linux/v6.10-rc2/source/include/linux/spinlock.h=
#L574

Regards,
Markus