Received: by 2002:ab2:68c1:0:b0:1fd:9a81:d0e4 with SMTP id e1csp606887lqp; Sun, 9 Jun 2024 10:33:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUbTiu0m9EP19T4EPkNLaSynI3mfiyWNkdS5VI6WgiePNX6lmFGe43zDNVLrWyMjnRFE1R7gES8CanrgG3Lq7tt3h0tXAQRiOhw/30w7g== X-Google-Smtp-Source: AGHT+IHXY0JiDPAwrvR6Noh5l/+F/qDc+vTqiGQmQraJh0ZRl1wYiMm+e4+Ak6OjLKrFbAMrB3PT X-Received: by 2002:ad4:5427:0:b0:6b0:5aec:7c02 with SMTP id 6a1803df08f44-6b05aec7e84mr60262176d6.6.1717954415273; Sun, 09 Jun 2024 10:33:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717954415; cv=pass; d=google.com; s=arc-20160816; b=lkaHWFhzAqBVsP/93lQzFB4N5mfeZIHSe0NkSpCzv2JUhJ5ydch6TPujyFPQbO28IG oR6djbpPnfrdEe7oNkTQ95Fr/WOYSLvYiM9UZauntm7GPvVmCDaNDRb/89mx3w0svYyr UF/o3cnRfcStWGufrCvIw3A8wB6OzgCvxtecPir9exw2QIR2vfYE/u6bQiIRwE4ei9vQ qojSw29JRDb5lmf210GDZ1GUGAWxUNHZQOh1o8VmeBGJ6zaBd80y/+Z2/Qv0/Ap5znGV rzx3niwW5l1xXmjawB1PM5CqaxYCOlMwV3bYT4pJkSjmnjbYRJiv+Nq+rc7kBKWhAXf5 buWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MAUO7plWGa67wBMBGd5bUPelX5Au5el0QUJC2t0xUxA=; fh=m8lceV5DWHnwveKbrONLDST7cTjZNXFbc5N2JkJ0y6I=; b=IHpNxD0wfA67Q3/fNPXQxa0Uw8YQ778egCEdfaZokIcLze9ZgIUop1BemfBBveLM9b JitZ+g613fIJa4H8sk8/Re5PhsQa8jDqEqY42OBw1d0xomsd7BDiEu01nSTBLO/Tk8HL jJxR/NFB0Fo//XvDyCQaUf82CKbuc7AzNBflV8hkGykaw3ay/7pTxuq8c6WpToxS4fH3 XKVrfd4BY/Yb8LYxk8ImTeSCu2AvzBUak1CgJc4V97A78tt634HvDIHBvL9WQytyrJVn yoNkUGrKMKUNDl0cnhzNpRWzClcNXrGiHWuabeGzMgGRQ2FZmyjVG7nsarqZ5RwVndwd x2iA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jafSMxQ+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-207443-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207443-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6b07ff887c1si899856d6.169.2024.06.09.10.33.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jun 2024 10:33:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207443-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jafSMxQ+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-207443-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207443-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EA4EA1C20962 for ; Sun, 9 Jun 2024 17:33:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 45DDA481A4; Sun, 9 Jun 2024 17:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jafSMxQ+" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BCB0D2E5; Sun, 9 Jun 2024 17:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717954407; cv=none; b=YhRzeHwIKMPwQiRyhBu10dQOzG44nHH606W+V6Lbt98eqUZSsypcY+y6P0hSmWLGxfvcpgMSMI91RqrkfDpyAV5e3TmOFVxFzZFnp4twvqJ1mfDmo8a+xbc+KcUJAPUPOMRmgPwGliH5souGyBjTxZ3ku6E0NoLZMoJGF97M4PI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717954407; c=relaxed/simple; bh=CBcnhStXol0Ia+umXn8moK4bXWC4G6yis63nfVjQ67M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fE1bfvVPCmC1J+Iz+FQyAXMBO3AfnGuG0Zpy9IpbByg5WKmvTE4iRWkd1XNnXjd68b2trrJtY8GsikcmD/Ma47h2seLczmuygmiNgHYlWN4J3NCFkWx99+nH0L41klQkixhJ9mYWUcNUo8TFR0o5SFDlN/kulurAp1SDmvmasGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jafSMxQ+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A67EC2BD10; Sun, 9 Jun 2024 17:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717954405; bh=CBcnhStXol0Ia+umXn8moK4bXWC4G6yis63nfVjQ67M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jafSMxQ+rfGLKTi2b6pV8wSjMONVIwt2fqfcu96DKNdtOh6peW+TFiWIJ+TjkBI0n Zu07YZKDxrKwFIbnYGNpiyJ+3nu3zSufIAc4l6FhXVoKzRdPiOICza9H01Zjc4RQWj FpKcHBg0BbzhFmNTBjMwHYND94bWa+lsrvF5n5OS6Ij8FylUHjcwkfwi80WQlmALrb 69pIqC9KEYvSYSCr70zJ9pGD14i9ECgxuNmuBuK/Z2SjxQ/oezq7YTd7gR9Q2KG2PD TFJoF0eHtqzCbEaQQc85lI99TdPXPlKfcm6Fzvo7pkQp57fAcmwuAKm3bjV53pEOAn 6IKQc1drKrCxg== Date: Sun, 9 Jun 2024 19:33:21 +0200 From: Alejandro Colomar To: Mark Brown Cc: Dev Jain , linux-man@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de, mark.rutland@arm.com, ryan.roberts@arm.com, suzuki.poulose@arm.com, Anshuman.Khandual@arm.com, DeepakKumar.Mishra@arm.com, AneeshKumar.KizhakeVeetil@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] signal.7: Clearly describe ucontext kernel dump to userspace Message-ID: References: <20240607123119.769044-1-dev.jain@arm.com> <20240607123119.769044-2-dev.jain@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t7t3p7hirvo5uufk" Content-Disposition: inline In-Reply-To: --t7t3p7hirvo5uufk Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable From: Alejandro Colomar To: Mark Brown Cc: Dev Jain , linux-man@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de, mark.rutland@arm.com, ryan.roberts@arm.com, suzuki.poulose@arm.com, Anshuman.Khandual@arm.com, DeepakKumar.Mishra@arm.com, AneeshKumar.KizhakeVeetil@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] signal.7: Clearly describe ucontext kernel dump to userspace References: <20240607123119.769044-1-dev.jain@arm.com> <20240607123119.769044-2-dev.jain@arm.com> MIME-Version: 1.0 In-Reply-To: Hi Mark, Dev, On Fri, Jun 07, 2024 at 04:39:33PM GMT, Mark Brown wrote: > On Fri, Jun 07, 2024 at 06:01:18PM +0530, Dev Jain wrote: >=20 > > .I ucontext_t > > -object that is pointed to by the third argument of the signal handler.) > > +object that is pointed to by the third argument of the signal handler. > > +We emphasize on the fact that this object contains context information >=20 > s/We emphasize on the fact that/Note that/ >=20 > feels more idiomatic. Even more idiomatic is to jump straight to the point, without noting it. If it weren't notable, we wouldn't say it. :) >=20 > > +of the thread, present before jumping into the handler; the set of > > +blocked signals for the current thread would be updated from struct >=20 > s/would/will/ >=20 > > +sigaction only after > > +.I ucontext_t > > +has been dumped to userspace. This semantically makes sense since the Please use semantic newlines. See man-pages: $ MANWIDTH=3D72 man man-pages | sed -n '/Use semantic newlines/,/^$/p' Use semantic newlines In the source of a manual page, new sentences should be started on new lines, long sentences should be split into lines at clause breaks (commas, semicolons, colons, and so on), and long clauses should be split at phrase boundaries. This convention, sometimes known as "semantic newlines", makes it easier to see the effect of patches, which often operate at the level of individual sentences, clauses, or phrases. > > +context for which the signals have been blocked, remains only during > > +execution of the handler.) >=20 > I'd drop the "this semantically makes sense" and reword the last bit to > be something like "The ucontext reflects the state at the time the > signal is delivered rather than in the handler" for idiom reasons. Thank you both. Have a lovely day! Alex --=20 --t7t3p7hirvo5uufk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmZl52EACgkQnowa+77/ 2zISPw//YFBwIkNkOCIegtXdYoUMN4j9lZMglkuqPrE/WMJLHVb6XJ5URr2fDRBD yLDzJ+ow05U73WYmRsXwM3q1NwD3t3CCvl50gxCwQ+IGZ1TnBu1NNzo79hoM/lgH dgdbBMHGieK6XwYBtiWZLle/shy1wdBVvRae5lcfuCBh8NfYGWwwB5x4hSXf9Xao pfeSTRD6OAZoouu3oO6ZKlp/6CcvYbYxdMxR+UEQImPprXp0WyBP9fLIydY5JSpq +TloFpJXWkTYrlxbRLe8fcsIwJ5iDtz1hD5GpIPXosp/PHLjexot/d89Ixs/7pa6 rzdyrXMvrSYF+8vd4wCJjuRB+abewra5mn03b8pBs2Y9Lbqg8rb2QLo/OT3zIom5 Km5lVLCTpitZCJKnp32rk1eomz7FHiSzYsPdPqXg71DG9J0y0JU20ZBy8ZCu+ZsM mzJ+XKkbC9bdAyuGnX1tbPxj43PNhVWfxRq8ZTmDr6/OaJDBoFS8mG+suP0THW13 rVOANNeljHABKHleiUEpXZKExZTq5n0RaNHCw3C8aoKN2Drsb1iCqLqyuwklin/b /ILzChdYE2988Olnpm86pAaWAsR6T6jkHTFZaSDEH4lL0Z55GtpRWV7wF0kVOD6i LcCtG0mhXbNwMrXlRost/n+DM3vc0/RfLDPGqDlpHAeh1Ly5s98= =W4Or -----END PGP SIGNATURE----- --t7t3p7hirvo5uufk--