Received-SPF: pass (google.com: domain of linux-kernel+bounces-207511-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Armin Wolf <W_Armin@gmx.de>
To: rafael@kernel.org,
	lenb@kernel.org
Cc: linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI: acpi_pad: Still evaluate _OST when _PUR evaluation fails
Date: Sun,  9 Jun 2024 23:09:08 +0200
Message-Id: <20240609210908.4470-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:0Wr9t1P7ckI=;NM4vT9gB8wBaHD0Z2EdjLhRLG0H
 84tqMLX9FAWEOtSY8WzKKfvzXh3wNfipzdsQ4bknWj+zJxLhxO7MpeK+6gKOcrz2uHWV4a0h3
 RwdNEd+3n0wPL+bRHTol4JfqfGvxkL4c7kCUJA+PojOpRs3A7hjreEY9vUixU6qGn2nkZVdjU
 d1WydVH3jQcr9gabYMCWr4rsCCED40ruxqW8Nap7ujF+O5tjZkB2kK7MbEHBaTsl+3H0G+6Jo
 NFTUKBumjzQ+gZcbtZCupRmH+dFzXiCkJCDQBEfQvgXH5grF5Z9geOP+CM2qVQiwqWhBs49LR
 ZJnnfeUncfuwPkVxblfLZ+uJ9/EEFBAi9AlQ2GxPi68fISajJEkzdZUDNoGBwmuoHRyd9BLCL
 DT2PIl1QUEqnO5i2eHp14n6vs5c9s9gsOlyEt7Yh72mAWl2yrBMUCEMq2nGCdg1JOAezxG0Ug
 lJ+Zz8/7jhm3WouSj9njUS1Twj6gqYg7JttA/jBol14N29LVo13yTqSdv+UfU/v4Nx4bEVED8
 d6TuURXpTO54PoUTHc0pCndKV4qFZ1SwLHuFhWlbVc0gc+gqb/AmBxZcSD89J7d9cA32ynMxA
 8N2UUp1WLJQH2ebpmDeZPmfuoANzIs1OUGh0zmaLpFzY+FP6hOLwOTFfHOUrdW8a7w+lN10b1
 1HuzlDev/XMIN+MWCUzfoUYrrgjxQ2GJS3N1GFrrmkz5ooOWOWjMaYMaCojOHB9UAn7FSMJUN
 7fmUDAeWfGD2/RdIEVpESMW6fvGvS8/wS/b4tWSw+/5Zgz3G0NjAcpxScYb0OY9FASV4m972k
 sBUSWtUEJQlosZvrPfUIHmIXCJ/WotxJ3gXoVdJgxlpUA=

The ACPI specification says that if no action was performed when
processing the _PUR object, _OST should still be evaluated, albeit
with a different status code.

Evaluate _OST even when evaluating _PUR fails, to signal the firmware
that no action was performed.

Compile-tested only.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/acpi/acpi_pad.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
index bd1ad07f0290..350d3a892889 100644
=2D-- a/drivers/acpi/acpi_pad.c
+++ b/drivers/acpi/acpi_pad.c
@@ -25,6 +25,10 @@
 #define ACPI_PROCESSOR_AGGREGATOR_CLASS	"acpi_pad"
 #define ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME "Processor Aggregator"
 #define ACPI_PROCESSOR_AGGREGATOR_NOTIFY 0x80
+
+#define ACPI_PROCESSOR_AGGREGATOR_STATUS_SUCCESS	0
+#define ACPI_PROCESSOR_AGGREGATOR_STATUS_NO_ACTION	1
+
 static DEFINE_MUTEX(isolated_cpus_lock);
 static DEFINE_MUTEX(round_robin_lock);

@@ -382,16 +386,23 @@ static void acpi_pad_handle_notify(acpi_handle handl=
e)
 		.length =3D 4,
 		.pointer =3D (void *)&idle_cpus,
 	};
+	u32 status;

 	mutex_lock(&isolated_cpus_lock);
 	num_cpus =3D acpi_pad_pur(handle);
 	if (num_cpus < 0) {
-		mutex_unlock(&isolated_cpus_lock);
-		return;
+		/* The ACPI specification says that if no action was performed when
+		 * processing the _PUR object, _OST should still be evaluated, albeit
+		 * with a different status code.
+		 */
+		status =3D ACPI_PROCESSOR_AGGREGATOR_STATUS_NO_ACTION;
+	} else {
+		status =3D ACPI_PROCESSOR_AGGREGATOR_STATUS_SUCCESS;
+		acpi_pad_idle_cpus(num_cpus);
 	}
-	acpi_pad_idle_cpus(num_cpus);
+
 	idle_cpus =3D acpi_pad_idle_cpus_num();
-	acpi_evaluate_ost(handle, ACPI_PROCESSOR_AGGREGATOR_NOTIFY, 0, &param);
+	acpi_evaluate_ost(handle, ACPI_PROCESSOR_AGGREGATOR_NOTIFY, status, &par=
am);
 	mutex_unlock(&isolated_cpus_lock);
 }

=2D-
2.39.2