Received-SPF: pass (google.com: domain of linux-kernel+bounces-207533-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
Date: Mon, 10 Jun 2024 00:41:54 +0200
From: Dragan Simic <dsimic@manjaro.org>
To: linux-kbuild@vger.kernel.org
Cc: masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu,
 linux-kernel@vger.kernel.org, stable@vger.kernel.org, didi.debian@cknow.org
Subject: Re: [PATCH] kbuild: Install dtb files as 0644 in Makefile.dtbinst
In-Reply-To: <ae087ef1715142f606ba6477ace3e4111972cf8b.1717961381.git.dsimic@manjaro.org>
References: <ae087ef1715142f606ba6477ace3e4111972cf8b.1717961381.git.dsimic@manjaro.org>
Message-ID: <10bef38ea944a42d591435e024f70326@manjaro.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit

+Cc: stable@vger.kernel.org
+Cc: didi.debian@cknow.org

On 2024-06-09 21:32, Dragan Simic wrote:
> The compiled dtb files aren't executable, so install them with 0644 as 
> their
> permission mode, instead of defaulting to 0755 as the mode.
> 
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>

Actually, some Linux distributions, including Debian, [1][2] already 
include
fixes in their kernel package builds to change the file permissions to 
0644.
Thus, let's have this fix propagated into the stable kernels, to allow 
such
distributions to remove their downstream fixes.

Fixes: aefd80307a05 ("kbuild: refactor Makefile.dtbinst more")

[1] https://salsa.debian.org/kernel-team/linux/-/merge_requests/642
[2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/749

> ---
>  scripts/Makefile.dtbinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.dtbinst b/scripts/Makefile.dtbinst
> index 67956f6496a5..9d920419a62c 100644
> --- a/scripts/Makefile.dtbinst
> +++ b/scripts/Makefile.dtbinst
> @@ -17,7 +17,7 @@ include $(srctree)/scripts/Kbuild.include
>  dst := $(INSTALL_DTBS_PATH)
> 
>  quiet_cmd_dtb_install = INSTALL $@
> -      cmd_dtb_install = install -D $< $@
> +      cmd_dtb_install = install -D -m 0644 $< $@
> 
>  $(dst)/%: $(obj)/%
>  	$(call cmd,dtb_install)