Date: Wed, 6 Feb 2008 14:00:04 +0100
From: Pavel Machek <pavel@ucw.cz>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: ?????? ??????????? <penguinista@mail.net.mk>, Greg KH <greg@kroah.com>,
       Arjan van de Ven <arjan@infradead.org>,
       Shaohua Li <shaohua.li@intel.com>, lkml <linux-kernel@vger.kernel.org>,
       linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>
Subject: Re: PCIE ASPM support hangs my laptop pretty often
Message-ID: <20080206130004.GC26817@elf.ucw.cz>
References: <200802051840.05237.penguinista@mail.net.mk> <20080205185100.GA4633@kroah.com> <47A8CE10.4010807@intel.com> <200802060105.45363.penguinista@mail.net.mk> <47A8FDDF.6080503@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47A8FDDF.6080503@intel.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1823
Lines: 41

On Tue 2008-02-05 16:22:55, Kok, Auke wrote:
> ?????? ??????????? wrote:
> >>>>> I've patched my kernel with the PCIe ASPM and after setting
> >>>>> echo powersave > /sys/module/pcie_aspm/parameters/policy
> >>>>>
> >>>>> I started to experience random hangs of my laptop.
> >>>>> Hardware info:
> >>>>> Thinkpad x60s 1704-5UG
> >>>> the x60's chipset doesn't support ASPM properly afaik... bad idea.
> >>> Well, the code shouldn't then cause a crash of the machine :)
> >> The user enabled it specifically (where it is disabled by default)
> >>
> >> ASPM has been crashing e1000(e), which is why I've recently merged a patch
> >> to disable L1 ASPM for the onboard 82573 nic on those platforms.
> >>
> >> this new infrastructure should work in the default configuration - enabling
> >> ASPM where this system leaves it disabled is expected to give problems
> >> unless you know what you are doing.
> > 
> > In my defense, the patch documentation didn't say it doesn't work with my 
> > hardware, nor that it hangs the chipset :) and the promised 1.3w surelly 
> > looked nice.
> > 
> > So, are there any benefits of ASPM if I have it in the kernel but it's set to 
> > default? I got the impression that "default" means not much power savings?
> 
> did the Kconfig not come with a big fat (EXPERIMENTAL) ?

(EXPERIMENTAL) is something different from (KNOWN BROKEN).

If we know about broken setups, we should probably be blacklisting
them.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/