Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp167658lqp; Sun, 9 Jun 2024 23:07:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX449IEe96zGYzgnuo8QHBZVHI1WQ2vobxrPD9nMZ8Xqs/uas/6ItkLPVyR3s/v1h2HoUaDODCIy4R/HI9LOX452c75K8PuX+ub+INAKw== X-Google-Smtp-Source: AGHT+IFUjSve77pvu+FeJpR0rrbb5L2s/vuckMA7gClLzbxFwXurgL/za/vMETLqaDv7tAC8MqiD X-Received: by 2002:a05:6a00:2e85:b0:704:2882:5881 with SMTP id d2e1a72fcca58-70428825e31mr7268695b3a.11.1717999673095; Sun, 09 Jun 2024 23:07:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717999673; cv=pass; d=google.com; s=arc-20160816; b=y72iA6VzVJyFO2aFJLEw+k+9xSHAl7X+VeYpWAsSdwYlkZ4x6OIio8NYox0DHyyewq INxy+kEnEPy5ytsBhOiYJnrP+2Mjs6RpSFq7ZdedGKoGEwTPn9K8RTPODwiAxqr/XDNl EAUqSHnxmdtDl7Wt16aYabTb+WXmMLTe2dGxs6UmzJ/lqZxfSAv7X6puqKJY0rj9oVse NMq0fCFP94TZ3MTmt5g6tSxm99iToBSnu4W7iCR6RChrplFs0CchB554cBQdeXu8G7N5 xr4l8QTnqlIKQp5jLTz6wmg3GUjA4wycLvhyx3rNadyM6yQipjCGxESrSzDQ8mpW0Bxt ZRmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:organization:subject :cc:to:from:date:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence; bh=7cfxhwrc45iQsvuUQ5urslV+jURgJOH5SfXAYjzNQTA=; fh=tZs145GEaRpRPd94tXd2oOgS8dsYTYmNF2MdEJfhwBc=; b=UwTqg/EUUw1hYcilfeHacyTNBVc83zUbNKW292X+WQtQKsK8GyQodPsxDiI2VWBKX6 mx2QpR2ZB9/JYVcAK/gWrc/AIk3w9xsZR68PxVprRTKM/SuiZQg/a8Ak1SZhrJ6SMMZ3 Lpt/ESRohM4wXdjbDPbPKWsSXdzPWmuAoN00GUztPO6e6lRqvk1hUW5Z8sc3rEzKGkm0 C1WqpC+/UZzC2xvAI8zEibcXJQInem/NvQRIieL9QQwcUuKSs4U5+36I2upJFOjgA77G 67XeG/EB3vxbRzRRVNPelj/7t2opQuszQr9IUCd24dsGgqrwAIzRfee4C1/1Tmks+6IM 2pFA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-207720-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207720-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6de208317f0si7340732a12.175.2024.06.09.23.07.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jun 2024 23:07:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207720-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-207720-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207720-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2F0DF283431 for ; Mon, 10 Jun 2024 06:04:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5E8E815EA6; Mon, 10 Jun 2024 06:04:28 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 916FADDB8; Mon, 10 Jun 2024 06:04:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717999467; cv=none; b=OwgObNlfycbYt5ns5O5GKkqFb9Us3ZyRf8VFhaqqtVoIPwDKMAr9E+syWD7pppBL6eoVbwpOnjqzGbqD2oHW35kR0+f1XMXJn2w3OEK3eOgSEaXTD2FPfJjzlnGBysqW4RebJIJDVtv9wDeaqW7qO1ViikVEf7CWt3mQiJrCMlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717999467; c=relaxed/simple; bh=cSQdX4BBYMrswHnIrE7sy+aIIFqOv+WYoxhqcbK1I0M=; h=MIME-Version:Content-Type:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID; b=R/XUwbzSTgaSWh+VY3O0TAa/6MhrMp2hZ2DQBqsV3bzKs/I+sj93G8ikKkWMxYc9wiSEX9XfEuEK42gMC3dTPgikv8pE4Ibza/P4FUFPvii2HVKBllQ8s0nrnd2XdkCoQnDGKH+dyxORGW3h6s4EKpvXCPJ4Loi+fLCiEbR2d0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sGY8d-0081Zp-BT; Mon, 10 Jun 2024 08:04:15 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGY8c-007Uab-NP; Mon, 10 Jun 2024 08:04:14 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 581C3240053; Mon, 10 Jun 2024 08:04:14 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id D9D49240050; Mon, 10 Jun 2024 08:04:13 +0200 (CEST) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 595D9201B0; Mon, 10 Jun 2024 08:04:13 +0200 (CEST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 Jun 2024 08:04:13 +0200 From: Martin Schiller To: Vladimir Oltean Cc: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 12/13] net: dsa: lantiq_gswip: Add and use a GSWIP_TABLE_MAC_BRIDGE_FID macro Organization: TDT AG In-Reply-To: References: <20240606085234.565551-1-ms@dev.tdt.de> <20240606085234.565551-13-ms@dev.tdt.de> <20240607113652.6ryt5gg72he2madn@skbuf> Message-ID: X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 X-purgate-type: clean X-purgate-ID: 151534::1717999455-C0C438CF-D4D8639C/0/0 X-purgate: clean On 2024-06-07 16:27, Martin Schiller wrote: > While looking again at this diff above, I noticed that val[0] is set > incorrectly. Shouldn't it be either "port << 4" or (after the previous > patch) > "FIELD_PREP(GSWIP_TABLE_MAC_BRIDGE_PORT, port);" instead of > "BIT(port)"? Please ignore this comment. The format of the port specification differs for static and dynamic (learned) entries.