Received-SPF: pass (google.com: domain of linux-kernel+bounces-207731-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 10 Jun 2024 08:21:09 +0200
From: Stanislav Jakubek <stano.jakubek@gmail.com>
To: laurent.pinchart@ideasonboard.com
Cc: brgl@bgdev.pl, conor+dt@kernel.org, devicetree@vger.kernel.org,
	krzk+dt@kernel.org, lee@kernel.org, linus.walleij@linaro.org,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pwm@vger.kernel.org, robh@kernel.org, ukleinek@kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: mfd: Add Analog Devices ADP5585
Message-ID: <ZmabVXaztPbp1ENV@standask-GA-A55M-S2HP>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240608141633.2562-2-laurent.pinchart@ideasonboard.com>

Hi Laurent,

> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 0a419453d183..91e62df4b296 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -39,10 +39,6 @@ properties:
>              # AD5110 - Nonvolatile Digital Potentiometer
>            - adi,ad5110
>              # Analog Devices ADP5585 Keypad Decoder and I/O Expansion
> -          - adi,adp5585
> -            # Analog Devices ADP5585 Keypad Decoder and I/O Expansion with support for Row5
> -          - adi,adp5585-02
> -            # Analog Devices ADP5589 Keypad Decoder and I/O Expansion
>            - adi,adp5589
>              # Analog Devices LT7182S Dual Channel 6A, 20V PolyPhase Step-Down Silent Switcher
>            - adi,lt7182s

seems like you removed the wrong comment here? With this, ADP5589 would have
a comment describing ADP5585.

Regards,
Stanislav