Received-SPF: pass (google.com: domain of linux-kernel+bounces-207722-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 10 Jun 2024 09:06:37 +0300
From: Mike Rapoport <rppt@kernel.org>
To: Leesoo Ahn <lsahn@ooseel.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Leesoo Ahn <lsahn@wewakecorp.com>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: sparse: clarify a variable name and its value
Message-ID: <ZmaX7cnUiWla9FCf@kernel.org>
References: <20240608152114.867961-1-lsahn@wewakecorp.com>
 <20240609140341.14ba3a1c62029771d60059ed@linux-foundation.org>
 <CANTT7qjthRWX+7m749mU_CmGUO1UEvY6O9yKsStm165Lz=tqAQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CANTT7qjthRWX+7m749mU_CmGUO1UEvY6O9yKsStm165Lz=tqAQ@mail.gmail.com>

On Mon, Jun 10, 2024 at 12:39:28PM +0900, Leesoo Ahn wrote:
> 2024년 6월 10일 (월) 오전 6:03, Andrew Morton <akpm@linux-foundation.org>님이 작성:
> >
> > On Sun,  9 Jun 2024 00:21:14 +0900 Leesoo Ahn <lsahn@ooseel.net> wrote:
> >
> > > Setting 'limit' variable to 0 might seem like it means "no limit". But
> > > in the memblock API, 0 actually means the 'MEMBLOCK_ALLOC_ACCESSIBLE'
> > > enum, which limits the physical address range based on
> > > 'memblock.current_limit'. This can be confusing.
> >
> > Does it?  From my reading, this meaning applies to the range end
> > address, in memblock_find_in_range_node()?  If your interpretation is
> > correct, this should be documented in the relevant memblock kerneldoc.

It is :-P
 
> IMO, regardless of memblock documentation, it better uses
> MEMBLOCK_ALLOC_ACCESSIBLE enum instead of 0 as a value for the variable.

Using MEMBLOCK_ALLOC_ACCESSIBLE is a slight improvement, but renaming the
variable is not, IMO.
 
> Best regards,
> Leesoo

-- 
Sincerely yours,
Mike.