Received-SPF: pass (google.com: domain of linux-kernel+bounces-207734-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-497-g97f96844c-fm-20240526.001-g97f96844
Precedence: bulk
MIME-Version: 1.0
Message-Id: <54c19328-35e2-4506-aa3a-a0b08813d873@app.fastmail.com>
In-Reply-To: <ZmSi5_-4mD4AaIJW@fedora>
References: <20240529094816.1859073-1-arnd@kernel.org>
 <ZmSi5_-4mD4AaIJW@fedora>
Date: Mon, 10 Jun 2024 08:24:51 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: =?UTF-8?Q?Jos=C3=A9_Exp=C3=B3sito?= <jose.exposito89@gmail.com>,
 "Arnd Bergmann" <arnd@kernel.org>
Cc: "Jiri Kosina" <jikos@kernel.org>,
 "Benjamin Tissoires" <bentiss@kernel.org>,
 "Rahul Rameshbabu" <rrameshbabu@nvidia.com>,
 "Fabio Baltieri" <fabiobaltieri@chromium.org>,
 "Ivan Gorinov" <linux-kernel@altimeter.info>,
 "Johannes Roith" <johannes@gnu-linux.rocks>, linux-input@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: uclogic: avoid linking common code into multiple modules
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 8, 2024, at 20:28, Jos=C3=A9 Exp=C3=B3sito wrote:
> On Wed, May 29, 2024 at 11:48:05AM +0200, Arnd Bergmann wrote:

>> @@ -154,10 +152,8 @@ obj-$(CONFIG_HID_WINWING)	+=3D hid-winwing.o
>>  obj-$(CONFIG_HID_SENSOR_HUB)	+=3D hid-sensor-hub.o
>>  obj-$(CONFIG_HID_SENSOR_CUSTOM_SENSOR)	+=3D hid-sensor-custom.o
>> =20
>> -hid-uclogic-test-objs		:=3D hid-uclogic-rdesc.o \
>> -				   hid-uclogic-params.o \
>> -				   hid-uclogic-rdesc-test.o
>> -obj-$(CONFIG_HID_KUNIT_TEST)	+=3D hid-uclogic-test.o
>> +hid-uclogic-test-objs		:=3D hid-uclogic-rdesc-test.o
>> +obj-$(CONFIG_HID_KUNIT_TEST)	+=3D hid-uclogic-test.o hid-uclogic-par=
ams.o hid-uclogic-params.o
>> =20
>>  obj-$(CONFIG_USB_HID)		+=3D usbhid/
>>  obj-$(CONFIG_USB_MOUSE)		+=3D usbhid/
>
> I tested your patch with:
>
> 	hid-uclogic-objs		:=3D hid-uclogic-core.o \
> 					   hid-uclogic-rdesc.o \
> 					   hid-uclogic-params.o
> 	obj-$(CONFIG_HID_UCLOGIC)	+=3D hid-uclogic.o
> 	[...]
> 	hid-uclogic-test-objs		:=3D hid-uclogic-rdesc-test.o
> 	obj-$(CONFIG_HID_KUNIT_TEST)	+=3D hid-uclogic.o hid-uclogic-test.o
>
> And I think it is a bit more clear and it looks like it does the trick
> removing the warning.

Right, that seems fine.

> Also, with that change only "EXPORT_SYMBOL_GPL(uclogic_rdesc_template_=
apply);"
> is required. The other EXPORT_SYMBOL_GPL can be removed.
>
> However, I'm not sure about what are the best practices using EXPORT_S=
YMBOL_GPL
> and if it should be used for each function/data in the .h file. Maybe =
that's
> why you added them.

No, having only the single export is better here, you should
have as few of them as possible. I did picked the more complicated
approach as I wasn't sure if loading the entire driver from the
test module caused any problems. Let's use your simpler patch
then.

     Arnd