Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp182766lqp; Sun, 9 Jun 2024 23:55:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWoZhp8DzXHTmD/qZ5ArR2BB9IrhFdu6yRkcc/soPl7VswYQ1VOO5jGP3xdt0yEAT59YgNVBn2FNHuCOZldtxVcpK89hYa07WCdHl6vqg== X-Google-Smtp-Source: AGHT+IEgy5LqY5Mn/R5qWIoL00K8KuvlpAgTd2Ml2cNjn5ixsCvCLCZWvdVHPstDIqt/4De7EmKO X-Received: by 2002:a17:906:6a12:b0:a6f:1021:3fa7 with SMTP id a640c23a62f3a-a6f10214bfamr279747966b.15.1718002523048; Sun, 09 Jun 2024 23:55:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718002523; cv=pass; d=google.com; s=arc-20160816; b=ROxUiFXTnepzUZCuRKNSNm7+53hQSD0EryJ8+5VN4MmhK9dkQ8jwEEzbsG2vuEBuDy 1CPFAixtjArFhB0yQSnmb3JNN98EbxZ84XrhuoNNJFsFvIv/gj8RUEgGeP170htgpfdB b5zPeqV8vlxkz6OEUHO1Oy1WDFqFdoNeVZ2U1SguNfvtYE9d67hql5mvUilaeNFIv56+ FOyS+3hFHnqElaW98ymwneTlL84wpE4LCWVM5tIvlE5/4skz+5miAGHYrOa/T85f4caE 7KPjuPhHYoWcSrWqC5yKeN6z5NkITkPztTkMOja8ay92tkkjFCfuklsB1PfkyzOofD2W zCsQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=9BY2lnviANQt5LFXardZ1Ja67QMdHaXFtOahZxl5GW0=; fh=HdsEmLb/ZQOZyF6HuwouA5xfIM4p4dE8ePt+8pyePfk=; b=QRlzyDMj1q6bB5qCnMHLygjjzOvQ9Rey87lgpgdE6o98bJi6P6c+69fELqKhcbPRSH b/MCF5gwLv6hKl1ZLFUp5ffPwdr2nu5dYWzZ6DulDq6u6awjT4Rxi7Yq+D9c0NP2O/KJ smRGWcMe/IBf6c9fpvitmodWBdTUdqn7Q6IJ6s3qxj3aXxsoTRpulLwHgGyNcDaimwhD SGaC2ZyXqk4HvFQgsVY2i2D2+0VLnKNBfKqCdxtE9dialqu6hLMxUGN440GGs45uXynS G7eCiCMQXtNWrddzySri5DS0o/tclbv36Bn+wrjkawJQgPX7H2CcmBNya3XXbuEK6PUX Dkkg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=rDnh85qo; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-207746-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207746-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6c8058d987si450522366b.30.2024.06.09.23.55.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jun 2024 23:55:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207746-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=rDnh85qo; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-207746-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207746-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C09251F21FAE for ; Mon, 10 Jun 2024 06:55:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D539D1A716; Mon, 10 Jun 2024 06:55:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="rDnh85qo" Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A3A1CA8A for ; Mon, 10 Jun 2024 06:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.72.192.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718002516; cv=none; b=pprrSKcGxRbLV/EamDAaxT4UyFPz4iIfM8DjS1vxPvormZdkZc4vpGsxqSGSZ8ybpxr/Bl6HAftSJ8YxdCT98Q7AHCsF+ZWDsZK+zmMOvCntn7SJ1s6fjwjI3OMbTSDB+nx3HnE9LpoiSbJzxy/FmPyC4IL7kNzKJVT6CvU9NB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718002516; c=relaxed/simple; bh=icWl2mW4gsTh79Dtr/VKuHNw5qX2jEW3RdcJNZb3MJ0=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=Mfh3MUO3Yi3YQXNb7RebSz8UhqbUbaSrLtIXevWGCjATllmPQaJQxbrY81SHBDJHyCVlI4W2oWwm9HF4A4+saKqD7OsDzLROpIW8WiUS+CymEJpXoPOHA28EqzvScNH38WOxTYpW+SAeePsj9xd7SLLPbLlcxm/rCFSDVuebpGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=rDnh85qo; arc=none smtp.client-ip=217.72.192.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1718002495; x=1718607295; i=markus.elfring@web.de; bh=9BY2lnviANQt5LFXardZ1Ja67QMdHaXFtOahZxl5GW0=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=rDnh85qobaTZx5plf8ucIjiGjCwBja+3QWE/P01kWherzc1ghScWR40sacik7cuo QWkmYPLX7trRudLGzykfNOOkmSDF74AYySu0qusN5wxcRgj8lYHnIrC/JDGxes+vr SiuNkmS+gyyH1jgiUDO//rM0xeAlzwuIKKyTAddfwGfN3Puwp5bkQ2dkCaVe39iJ+ Yz8Qqo/2ga+EbYUKy8KpJDnwDEU59ufGlrn4lCRDbN/5vDtSLii5YbmUJd+XfV1qa opV21U43yxswV4quw7p3xcEHfdLebcXoXUe0c8rvHVsGeUK7d+Fk73+9i21byOMEm uF9i0RGJrLiRX9KOZA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MUCz3-1rpv7k26cd-00PHkN; Mon, 10 Jun 2024 08:54:55 +0200 Message-ID: <2904522f-8981-459c-8f8a-5dfa6de40331@web.de> Date: Mon, 10 Jun 2024 08:54:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Alexandr Sapozhnikov , linux-nvme@lists.infradead.org, lvc-project@linuxtesting.org, Chaitanya Kulkarni , Christoph Hellwig , Sagi Grimberg Cc: LKML References: <20240607134340.11-1-alsp705@gmail.com> Subject: Re: [PATCH] drivers: nvme: target: core: deref after null Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240607134340.11-1-alsp705@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:uMo2DT30EkJwd/lQVOYtidkkkXOcQVOo4S3SIygw+m8jw8Qz6qf FlIwe3QTsMUAzR8NhF3h6PVroXnYEvom0CN6NHcHtDZ6q4lvkplTX8VKM6UnKbWHN//WVyA LaTJ4IyaBYFw4TQSOB2suhWbQ+YzAuIq9wa+9pketoVZEQPUTe1EVsjS0kNpzyXAOM3B9eG XIyqIVVRl+FHZ72FLFULg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:7gBCsE6Z9MA=;0ar/JH+9Rf2g0rpBzMwAVqrPfrU OK7Y3Oi/zo2W7Zlm+U5rL4+34TyqaMZtNrLBRkqQ/QplOsiV3zWt2DrKdH7qolwKmta/I6g19 0S/DazL/MZz43fwwZK6nHFQeV3LKv+3Nn3opGb8CTp0yceg4RKMdQuuZ27uSiPGgmjpivtBw9 qxFHQ9/5Ab7Ah8pLOnHgRtSaU+IjaeHV1bQxpPIGwEqV3ymg3tpBDbp607G7YV5xwJKeYGxiQ K1JOG/loEY+hpr1beWBgG5J+SRALwL4H5gfk5Q+a5ixZcNKTSIWHjraTZH4jfJDuMfFWiKTRS ZNkBniFP+GmR45l4+8AVBFP0W6I6+PZM6CTGz+Uo2cFdwJAhO5rMmjYabMA/dT+nft9EpG797 9MRqj8TDJVJBoiEWFiOQmrjDWexc4CBzdtvnyTuzpFXjVFaM2WGTKxLd1Qr8B+sQ+gUXWLnK8 dGsc6XHeICYsfMJWEwO3Ts1tzDRMWK+bv8NrJ+FB3KYlQpbnfurQpPyUtanZ7lf7eqh2oF4dx P7mdW852WmPQxVwPUXalSh7k3kXD4vLQBCisS4kAEXwdN1kVLhZz2AlZbVr6NEVjqVjg2sH5+ jNeIcxCfvjCw/S0qo/uqHtd6+0Vbqas8IllgNtFZDbo7M87nCqMygXNfIY/OxfrNGehqeVDiH tmg2RRGkPco2wqvpe2mVxgp8KMmr5MC6Cz+ekfq1EL7DdvPDoswEmaJK+ylP9Tx8PT0b+Z04+ WKxB3JefCSdChNUnrBsXS1As0/G1vJ8IrGtaentloABXrGY018RkYtXUWxEUeW9zJ7BILwsES oadLL8j5NQrJYFJ4kENn+ddBJTRahAq0vbLsfn3kl51c0= > After having been compared to a NULL value at core.c:813, > pointer '(**sq->ctrl).sqs' is dereferenced at core.c:838. * Please choose another imperative wording for an improved change descript= ion. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/submitting-patches.rst?h=3Dv6.10-rc2#n94 * Would you like to add the tag =E2=80=9CFixes=E2=80=9D accordingly? * How do you think about to use the summary phrase =E2=80=9CAvoid null poi= nter dereference in nvmet_sq_destroy()=E2=80=9D? * Is the subsystem specification =E2=80=9Cnvmet=E2=80=9D more appropriate? Regards, Markus