Received-SPF: pass (google.com: domain of linux-kernel+bounces-207749-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <3c0235d7-219f-4a3e-bb58-eb662f61f570@suse.com>
Date: Mon, 10 Jun 2024 09:59:23 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/cpu: Consolidate identical branches
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org
References: <20240521124832.486390-1-nik.borisov@suse.com>
Content-Language: en-US
From: Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20240521124832.486390-1-nik.borisov@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 21.05.24 г. 15:48 ч., Nikolay Borisov wrote:
> It's pointless to have 2 identical branches one after the other, simply
> collapse them in a single branch. No functional changes.
> 
> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>

Ping

> ---
>   arch/x86/kernel/cpu/common.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 69265c0acaea..369037a166fd 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1732,12 +1732,11 @@ static void generic_identify(struct cpuinfo_x86 *c)
>   {
>   	c->extended_cpuid_level = 0;
>   
> -	if (!have_cpuid_p())
> +	if (!have_cpuid_p()) {
>   		identify_cpu_without_cpuid(c);
> -
> -	/* cyrix could have cpuid enabled via c_identify()*/
> -	if (!have_cpuid_p())
> +		/* cyrix could have cpuid enabled via c_identify()*/
>   		return;
> +	}
>   
>   	cpu_detect(c);
>