Received-SPF: pass (google.com: domain of linux-kernel+bounces-207753-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <2d7164356496ab910bdbcac471f91d874b9e075d.camel@gmail.com>
Subject: Re: [PATCH v3 2/4] iio: temperature: ltc2983: convert to
 dev_err_probe()
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>, Nuno Sa <nuno.sa@analog.com>
Cc: Petr Mladek <pmladek@suse.com>, Lars-Peter Clausen <lars@metafoo.de>, 
 Olivier Moysan <olivier.moysan@foss.st.com>, Jyoti Bhayana
 <jbhayana@google.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Chris Down <chris@chrisdown.name>, John Ogness <john.ogness@linutronix.de>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andi Shyti
 <andi.shyti@kernel.org>, linux-kernel@vger.kernel.org, 
 linux-iio@vger.kernel.org
Date: Mon, 10 Jun 2024 09:11:28 +0200
In-Reply-To: <20240608190600.622dfd7f@jic23-huawei>
References: <20240606-dev-add_dev_errp_probe-v3-0-51bb229edd79@analog.com>
	 <20240606-dev-add_dev_errp_probe-v3-2-51bb229edd79@analog.com>
	 <20240608190600.622dfd7f@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Sat, 2024-06-08 at 19:06 +0100, Jonathan Cameron wrote:
> On Thu, 6 Jun 2024 09:22:38 +0200
> Nuno Sa <nuno.sa@analog.com> wrote:
>=20
> > Use dev_err_probe() (and variants) in the probe() path. While at it, ma=
de
> > some simple improvements:
> > =C2=A0* Explicitly included the err.h and errno.h headers;
> > =C2=A0* Removed some unnecessary line breaks;
> > =C2=A0* Removed a redundant 'else';
> > =C2=A0* Added some missing \n to prink.
> >=20
> > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> > ---
>=20
>=20
> > @@ -1296,8 +1268,8 @@ static int ltc2983_reg_access(struct iio_dev
> > *indio_dev,
> > =C2=A0
> > =C2=A0	if (readval)
> > =C2=A0		return regmap_read(st->regmap, reg, readval);
> > -	else
> > -		return regmap_write(st->regmap, reg, writeval);
> > +
> > +	return regmap_write(st->regmap, reg, writeval);
> > =C2=A0}
>=20
> Unrelated.
>=20
> Otherwise updates look correct to me.

Yeah, I know. It was simple enough that I sneaked it in and did mentioned i=
t in
the commit message hoping it would make the change acceptable in here :)

- Nuno S=C3=A1