Received-SPF: pass (google.com: domain of linux-kernel+bounces-207765-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <8cb3752a46f83fbadbc6d33105004f2986a470f5.camel@gmail.com>
Subject: Re: [PATCH v7 5/9] iio: adc: ad7173: refactor ain and vref selection
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 David Lechner <dlechner@baylibre.com>,  linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org, Dumitru Ceclan
 <mitrutzceclan@gmail.com>
Date: Mon, 10 Jun 2024 09:23:49 +0200
In-Reply-To: <20240607-ad4111-v7-5-97e3855900a0@analog.com>
References: <20240607-ad4111-v7-0-97e3855900a0@analog.com>
	 <20240607-ad4111-v7-5-97e3855900a0@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-06-07 at 17:53 +0300, Dumitru Ceclan via B4 Relay wrote:
> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
>=20
> Move validation of analog inputs and reference voltage selection to
> separate functions to reduce the size of the channel config parsing
> function and improve readability.
> Add defines for the number of analog inputs in a channel.
>=20
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> ---

One minor nit that maybe can be tweaked while applying. Anyways, no need fo=
r v8
just because of it:

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/iio/adc/ad7173.c | 62 +++++++++++++++++++++++++++++++++----=
----------
> -
> =C2=A01 file changed, 43 insertions(+), 19 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 8631f218b69e..1257303b0cf6 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -60,6 +60,7 @@
> =C2=A0#define AD7173_CH_SETUP_AINPOS_MASK	GENMASK(9, 5)
> =C2=A0#define AD7173_CH_SETUP_AINNEG_MASK	GENMASK(4, 0)
> =C2=A0
> +#define AD7173_NO_AINS_PER_CHANNEL	2
> =C2=A0#define AD7173_CH_ADDRESS(pos, neg) \
> =C2=A0	(FIELD_PREP(AD7173_CH_SETUP_AINPOS_MASK, pos) | \
> =C2=A0	 FIELD_PREP(AD7173_CH_SETUP_AINNEG_MASK, neg))
> @@ -906,13 +907,48 @@ static int ad7173_register_clk_provider(struct iio_=
dev
> *indio_dev)
> =C2=A0					=C2=A0=C2=A0 &st->int_clk_hw);
> =C2=A0}
> =C2=A0
> +static int ad7173_validate_voltage_ain_inputs(struct ad7173_state *st,
> +					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int ain0, unsigned int
> ain1)
> +{
> +	struct device *dev =3D &st->sd.spi->dev;
> +
> +	if (ain0 >=3D st->info->num_inputs ||
> +	=C2=A0=C2=A0=C2=A0 ain1 >=3D st->info->num_inputs)
> +		return dev_err_probe(dev, -EINVAL,
> +				=C2=A0=C2=A0=C2=A0=C2=A0 "Input pin number out of range for pair
> (%d %d).\n",
> +				=C2=A0=C2=A0=C2=A0=C2=A0 ain0, ain1);
> +
> +	return 0;
> +}
> +
> +static int ad7173_validate_reference(struct ad7173_state *st, int ref_se=
l)
> +{
> +	struct device *dev =3D &st->sd.spi->dev;
> +	int ret;
> +
> +	if (ref_sel =3D=3D AD7173_SETUP_REF_SEL_INT_REF && !st->info-
> >has_int_ref)
> +		return dev_err_probe(dev, -EINVAL,
> +			"Internal reference is not available on current
> model.\n");
> +
> +	if (ref_sel =3D=3D AD7173_SETUP_REF_SEL_EXT_REF2 && !st->info->has_ref2=
)
> +		return dev_err_probe(dev, -EINVAL,
> +			"External reference 2 is not available on current
> model.\n");
> +
> +	ret =3D ad7173_get_ref_voltage_milli(st, ref_sel);
> +	if (ret < 0)
> +		return dev_err_probe(dev, ret, "Cannot use reference %u\n",
> +				=C2=A0=C2=A0=C2=A0=C2=A0 ref_sel);
> +
> +	return 0;

could be return ad7173_get_ref_voltage_milli()...

- Nuno S=C3=A1