Received-SPF: pass (google.com: domain of linux-kernel+bounces-207776-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 10 Jun 2024 08:31:33 +0100
From: Conor Dooley <conor.dooley@microchip.com>
To: Conor Dooley <conor@kernel.org>
CC: Dave Stevenson <dave.stevenson@raspberrypi.com>, Laurent Pinchart
	<laurent.pinchart@ideasonboard.com>, <linux-media@vger.kernel.org>, Sakari
 Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab
	<mchehab@kernel.org>, Adam Ford <aford173@gmail.com>, Andrey Konovalov
	<andrey.konovalov@linaro.org>, <linux-kernel@vger.kernel.org>, Naushir Patuck
	<naush@raspberrypi.com>
Subject: Re: [PATCH v1] media: i2c: imx219: fix msr access command sequence
Message-ID: <20240610-wolverine-hanky-37cc8c409958@wendy>
References: <20240607-trimmer-pummel-b452ed15e103@spud>
 <20240607155704.GB1242@pendragon.ideasonboard.com>
 <CAPY8ntBNNOFR1nn05g4Y-SOv_tN0YJv9wygO=+S80-zA1oq7mg@mail.gmail.com>
 <20240607-celibacy-contend-c4a6be15804b@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="RQwjnWiVsjBImHpx"
Content-Disposition: inline
In-Reply-To: <20240607-celibacy-contend-c4a6be15804b@spud>

--RQwjnWiVsjBImHpx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 07, 2024 at 06:55:01PM +0100, Conor Dooley wrote:
> On Fri, Jun 07, 2024 at 06:29:49PM +0100, Dave Stevenson wrote:
>=20
> > > > ---
> > > > I got the report of this third hand, I don't have a device and can't
> > > > test this. I do wonder why the RPis get away with the sequence that
> > > > seemingly doesn't work for the guy that reported this to me. My the=
ory
> > > > is either that they noticed the sequence was wrong while adding some
> > > > other MSR access that is needed on this board while either cross
> > > > checking the values written or because the other MSR accesses didn't
> > > > take effect.
> >=20
> > Did the change fix it for the reporter? We're using the driver with no
> > changes to the register settings cf mainline.
> > Why it works on the Pi but not on a Microchip board is likely to be
> > something quite subtle.
>=20
> I've asked, maybe it turns out to just be the first of my suggestions,
> and they noticed it was not matching in passing.

Apparently it was the latter & they did need to fix the sequence to be
able to write the MSRs.

> They did introduce two
> additional MSR accesses, both outside of the range documented in the
> datasheets I could find online. They did have explanations for what those
> undocumented MSRs did (0x5040 and 0x5041) in the mail I got, but given
> it's third hand info to me, I dunno if we have the datasheet etc. I'll
> try to find out some more next week.

Seemingly what those two additional MSRs do is under NDA so I would have
no way of justifying a patch to add them or the devicetree property
required to know whether or not the additional MSR writes is needed. :)


--RQwjnWiVsjBImHpx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZmar1QAKCRB4tDGHoIJi
0nywAP9jiXVl7YlW5revw707dpMwBM18c+5dtlHTgE8jVUt9uwEA3uG5TXfEGThl
H/f1AFrVA5fpcSwZaV56fBU1J29Rewg=
=srXG
-----END PGP SIGNATURE-----

--RQwjnWiVsjBImHpx--