Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp208504lqp; Mon, 10 Jun 2024 01:08:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXVM0TilOA2j4j6+2WED1k9Jl7OUyM+jbqTs33vtG5jSfpadeCiy/M2sJlmBUmgbMwciG2hJ/jp2DHv39raRu9Z/1g7qm3R/NFNmlMGJA== X-Google-Smtp-Source: AGHT+IHCNASlyPYuPXDOy9HWTn5h1wRKJKSj8MQuCZpTmPxz0cyOR1JP+IrCEnub5PYEixMzw641 X-Received: by 2002:a17:902:f652:b0:1f6:3d8:cc09 with SMTP id d9443c01a7336-1f6d03a057amr100356935ad.45.1718006895717; Mon, 10 Jun 2024 01:08:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718006895; cv=pass; d=google.com; s=arc-20160816; b=jCATo1xzzYT0ccfWsQ2f4msZxcpiLo4+IlnCOlHUBiKgoPZPKI5FIcInZOdX1zeNFb q6vn89Sb0KFN8Y9oWBuI61+bfLNqUnf6iMMuUYW4gmIbIDtW2LqxtgXghXzqpQkyWZgz X6he37MJ70rXtOpte0N9zJfbGbHbH4LVLj5GLKz5uFuayTZoiK4iojvCdoTZ1o/PfQfp wxHxS64F+gND4Yk+4PPnGlWWlt7p0RRrR0NlqTm7X5a1qsQfvlDA9BevSTEQu3xmM67i pPhE6oCFgZcpdBZWLMY7+hMuLtVtH0KGcmzI/6SmlmHclEXYFyGFH1iK7pkd1+4lWXjI 4EiA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=mqCJnjHmhe1AmErrMnWA+oqbCYQa3cq3S1/88j1PYX4=; fh=1+GBUKKpRigPXizXGGSts8fsx4GmO9oH4VLeEq2L+mk=; b=BZdAYk3rd97TbuEOZ3aIYDfn/R5Y1j7z4vSEMxnQUr8l0Q5oid9wRGh7OBGUtw+aSs 2BSB+Yfiug5iaqczQC6L3nU7eagMISHbC0QzkFo40fZslct6JaTZecq0/0jP9RvgLiHC zyqk+KEzbiSpm/Cp/NRWXs0YHJxIOTtS7y5cV4lPm6tX07mmW75PQU1RW5bs0Wjj6Dr/ pw/el4OABR9xYNu0WTV0f27d1wuGnti+YqVq99xVvpThYwi9YSHkwc5ktRsYplCOHzK2 AxlaZYMcK04s/AfGUCuGqkfciHyyXGBUA8jTRJkcck6NwC+73HRWKWrwaI/cisjGowy0 j4ZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=D5NePrib; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-207802-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207802-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f6bd7603afsi71200135ad.85.2024.06.10.01.08.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 01:08:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207802-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=D5NePrib; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-207802-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207802-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F3E73282667 for ; Mon, 10 Jun 2024 08:08:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1380156448; Mon, 10 Jun 2024 08:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="D5NePrib" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4A02558BA for ; Mon, 10 Jun 2024 08:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718006887; cv=none; b=mKlRzn1sunjpwgx2ucdBWa6360CSBXZaKT8yj0NHXw71G9yCRH/8vUYBWULB+4ebTv8lw6Z4OfLmO5dLb15F2nJtTwL7QXr6hJeRRCD8sHFrHnfq2cTfyW1efMJX+fdGLMwS0XQgOEdLNyl/OkJf7PhxdkqB3/ODcmPLbIPH2vY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718006887; c=relaxed/simple; bh=+a4XyDtUsGwPIvUvhqNonD5lfzcSOMuMC24xSiBtXco=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fyRhc/XFzrcnJ/XZoahlh1lqjObRBxV6/xD2xpqM8/h/P3aZ05cQCkz7XEoocbcHGyyHwUICFUeKyUQ53y63G55YzonAFGByWu3b9fwbbcMJlwXqx8E9PvU2Pmzc9d6h/q3B8hJa+rykVkiFHIpOHRyKHqwWsABMBI54+vcIgTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=D5NePrib; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1718006884; bh=+a4XyDtUsGwPIvUvhqNonD5lfzcSOMuMC24xSiBtXco=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D5NePribMsVST4B2FtFE2Zr5cx66W8RZW36ExJ1UM//vid2ECn5F6DUrQoZlCOM74 YQMClvdCvYHJByKhzdzaot8O3FLaKXfnqSlmW6iLWr9jpxNZh84rz+DS6tK9N4imL9 FjuyphhdnKrxozXdFykRNP+GH/Panveqy5buMs9VJoGJhNMPFhjKEjKkC7Z2Q3Zp9S 7MFDGPX4fQbv05whQ3+GiBPOYS8wWr2IKVTdCjx+sdAczeMRfj2fbFmj6VxbAZ/qRk ELx7sx2gKLLBiR6ZfH6KkYjPrHYy8AyS+sTS4owFPVDQ8hS3pLMYUMMG71bRcQ3ESP aL99PxEoEaZwg== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 82AFF3780575; Mon, 10 Jun 2024 08:08:03 +0000 (UTC) Message-ID: <311dbd5e-60bf-4e09-981c-238e7a9970be@collabora.com> Date: Mon, 10 Jun 2024 10:08:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/mediatek: Log errors in probe with dev_err_probe() To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240606-mtk-disp-rdma-dev-err-probe-v2-1-3898621767b8@collabora.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240606-mtk-disp-rdma-dev-err-probe-v2-1-3898621767b8@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 07/06/24 01:52, Nícolas F. R. A. Prado ha scritto: > Use dev_err_probe() to log errors in the probe function of all drm > mediatek drivers. This avoids -EPROBE_DEFER return values from being > logged as errors, like the following: > > mediatek-disp-rdma 1c002000.rdma: Failed to add component: -517 > > As a side benefit it also standardizes the format of the error in the > log messages. > > Signed-off-by: Nícolas F. R. A. Prado Sweet! Reviewed-by: AngeloGioacchino Del Regno Cheers, Angelo