Received-SPF: pass (google.com: domain of linux-kernel+bounces-207919-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 10 Jun 2024 11:07:15 +0200
From: Martin Schiller <ms@dev.tdt.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch,
 f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
 krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 01/13] dt-bindings: net: dsa: lantiq_gswip: Add
 missing phy-mode and fixed-link
Organization: TDT AG
In-Reply-To: <ae996754-c7b9-4c46-a3dd-438ab35d6c67@kernel.org>
References: <20240606085234.565551-1-ms@dev.tdt.de>
 <20240606085234.565551-2-ms@dev.tdt.de>
 <ae996754-c7b9-4c46-a3dd-438ab35d6c67@kernel.org>
Message-ID: <c410ac7cce5fe6bf522bac6edb18440d@dev.tdt.de>
User-Agent: Roundcube Webmail/1.3.17

On 2024-06-10 10:55, Krzysztof Kozlowski wrote:
> On 06/06/2024 10:52, Martin Schiller wrote:
>> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> 
>> The CPU port has to specify a phy-mode and either a phy or a 
>> fixed-link.
>> Since GSWIP is connected using a SoC internal protocol there's no PHY
>> involved. Add phy-mode = "internal" and a fixed-link to describe the
>> communication between the PMAC (Ethernet controller) and GSWIP switch.
> 
> You did nothing in the binding to describe them. You only extended
> example, which does not really matter if there is DTS with it.
> 
> Best regards,
> Krzysztof

OK, so I'll update subject and commit message to signal that we only
update the example code.