Received-SPF: pass (google.com: domain of linux-kernel+bounces-207956-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 10 Jun 2024 11:39:39 +0200
From: Kory Maincent <kory.maincent@bootlin.com>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Oleksij Rempel <o.rempel@pengutronix.de>, Thomas
 Petazzoni <thomas.petazzoni@bootlin.com>, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org, Dent Project <dentproject@linuxfoundation.org>,
 kernel@pengutronix.de
Subject: Re: [PATCH net-next v2 3/8] netlink: specs: Expand the PSE netlink
 command with C33 new features
Message-ID: <20240610113939.41d86109@kmaincent-XPS-13-7390>
In-Reply-To: <m2bk4dm5ct.fsf@gmail.com>
References: <20240607-feature_poe_power_cap-v2-0-c03c2deb83ab@bootlin.com>
	<20240607-feature_poe_power_cap-v2-3-c03c2deb83ab@bootlin.com>
	<m2bk4dm5ct.fsf@gmail.com>
Organization: bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 07 Jun 2024 11:09:38 +0100
Donald Hunter <donald.hunter@gmail.com> wrote:

> Kory Maincent <kory.maincent@bootlin.com> writes:
>=20
> > From: "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com>
> >
> > Expand the c33 PSE attributes with PSE class, extended state information
> > and power consumption.


> >
> > diff --git a/Documentation/netlink/specs/ethtool.yaml
> > b/Documentation/netlink/specs/ethtool.yaml index 00dc61358be8..8aa064f2=
f466
> > 100644 --- a/Documentation/netlink/specs/ethtool.yaml
> > +++ b/Documentation/netlink/specs/ethtool.yaml
> > @@ -922,6 +922,22 @@ attribute-sets:
> >          name: c33-pse-pw-d-status
> >          type: u32
> >          name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-pw-class
> > +        type: u32
> > +        name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-actual-pw
> > +        type: u32
> > +        name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-ext-state
> > +        type: u8
> > +        name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-ext-substate
> > +        type: u8
> > +        name-prefix: ethtool-a- =20
>=20
> I see this is consistent with existing pse attributes in the spec, but
> are there enumerations for the state and status attributes that could be
> added to the spec?

Indeed, I can add the enum also in the spec.

Regards,
--=20
K=C3=B6ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com